Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect file argument to print_x functions #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Respect file argument to print_x functions #34

wants to merge 1 commit into from

Conversation

SECtim
Copy link

@SECtim SECtim commented Jan 2, 2024

The utils.print_x functions take a file argument that was not used in their implementation. This lead to errors and warnings being printed to stdout instead of stderr.

Fixes #33

@SECtim
Respect file argument to print_x functions
0b653a3 
The utils.print_x functions take a `file` argument that was not used in their implementation.
This lead to errors and warnings being printed to stdout instead of stderr.

Fixes iluxonchik#33
@iluxonchik
Copy link
Owner

Hello,

Thank you for creating an issue and taking your time to submit this merge request. I will review it soon. From a quick check, your code change seems correct. I'll will make sure that that doesn't break anything, and then work it into a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluxonchik iluxonchik Awaiting requested review from iluxonchik iluxonchik is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings are written to stdout instead of stderr
2 participants
@SECtim @iluxonchik