Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

KEYFORMATVERSIONS, KEYFORMAT attribute default handling #31

Open
kalemeister opened this issue Jan 11, 2016 · 1 comment
Open

KEYFORMATVERSIONS, KEYFORMAT attribute default handling #31

kalemeister opened this issue Jan 11, 2016 · 1 comment

Comments

@kalemeister
Copy link

An application I made that uses open-m3u8 has a section where it reads a playlist then creates a new one based on edited values in the original list. I noticed the original playlist didn't have the attributes KEYFORMATVERSIONS and KEYFORMAT. But the new one has the attributes with their default values.

I read the specification "HTTP Live Streaming draft-pantos-http-live-streaming-16". It states in there that these two attributes are optional and their omission means the default values will be assumed. So newly created playlists don't need to include these unless their values are non-default.

So I was wondering if this behavior would be desired (new playlists won't include these attributes unless they were specified before or their values are non-default). If so I'll try to work on it in a new fork.

This isn't an important issue nonetheless. The rewritten playlist with these two attributes included worked fine.

@kalemeister
Copy link
Author

I made the changes so that a new MediaPlaylist won't write these attributes to a new playlist file if their values are default. If a new list is build by 'buildUpon' and the previous list has these attributes then it will include them in the new file.

If you want to check it out let me know and I'll make a new fork with these changes after my current fork (of different changes) is done/closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant