Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname limited in number of characters #23

Open
krosk opened this issue Oct 12, 2016 · 3 comments
Open

Nickname limited in number of characters #23

krosk opened this issue Oct 12, 2016 · 3 comments
Milestone

Comments

@krosk
Copy link

krosk commented Oct 12, 2016

The official client can display nicknames with more than 12 characters, but you will not be able to manually write (that is, renaming through client) more than 12 chars.

While there has been no word that the client/server detect tampering of responses through checking the length of nicknames, this is a potential giveaway. You may want to issue a warning to users.

@malopetrov
Copy link

As of my understanding app doesn't change the nicknames. They are only displayed customized. No server comunication here.

@igoticecream
Copy link
Owner

I could add an option to truncate always 12 characters if it exceeds

@igoticecream igoticecream added this to the 1.5.0 milestone Oct 14, 2016
@alucas
Copy link

alucas commented Oct 31, 2016

If they start to check every details like this, their code will grow messy and hard to maintain. Idem for this module.

If they start doing that, It will probably be easier to intercept the anti-tempering function/message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants