Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change forest.continuum to forest.expected_flux #876

Open
andreufont opened this issue Apr 6, 2022 · 0 comments
Open

Change forest.continuum to forest.expected_flux #876

andreufont opened this issue Apr 6, 2022 · 0 comments

Comments

@andreufont
Copy link
Contributor

Once we are happy with the many ongoing PRs, we should address this confusing naming. We currently use forest.continuum to mean "continuum * mean flux*, but other continuum fitting codes will not want to use this, an will want to clearly separate these. Renaming the variable to continuum.expected_flux would at least make this clear and avoid confusion.

@iprafols iprafols mentioned this issue May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant