-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request #5
Comments
Thank you. |
some ideas on how to calc piece size etc. |
I see no reason for a user to set a number of pieces, as setting it involves manual size calculation from his side to devise a "proper" number. On the other hand setting size (in KiBs) manually is probably a good thing. As a whole, I think we better stick to some widely-used predefined values for various file sizes (something like mode Some useful links:
|
The reason i added this was because some torrent sites have a max size for the torrent files. Reducing number of pieces reduces the torrent size. The calc mode is what deluge uses. I think beta is the best. Setting a limit on the torrent size would be nice but I'm not sure how to handle it. I see no reason why we shouldn't support it. It's easy and with good defaults we should be covered |
Yes, but the same goal is already achieved with piece size option. How do you expect a user to set pieces number to control .torrent file size without some precalculations on his side? Maybe we need an option named like
|
Because of the pieces will be in the range of 1200 and 1800. Unless the file is to small to get the desired pieces or the file is simply to large to get the pieces it want with max piecesize. And if we want smaller pieces size you can set a new max piece size at the cost of more overhead, 16 mb might be over the top :p It's the follows torrent freaks guide the closest. Seeding a 200-300 gb torrent (not uncommon on tv torrent sites) with 1 mb piece size result in a huge overhead. |
Chunks under 32KiB are not practical considering current bandwidths, and over 16MiB are too havy load anyway. |
I have started on some of the changes i have listed. It needs a serious cleanup and more tests but it shows the direction i want to go. Ill send a pr when im done and you can just pick what you need or reject the entire thing :P, I just wanted to give you a heads up. https://github.com/Hellowlol/torrentool/tree/better_plx |
Ok, I'll watching from time to time. |
This is more a wish list then a feature request, I'm prob gonna send a pr for all them.
The text was updated successfully, but these errors were encountered: