Skip to content

Commit 888230a

Browse files
committed
simplify lefthook command
1 parent 9df0172 commit 888230a

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

app/javascript/ui/global/ErrorBoundary.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ class ErrorBoundary extends React.Component {
1010

1111
componentDidCatch(error, errorInfo) {
1212
this.setState({ error })
13-
if (process.env.NODE_ENV === 'development') {
14-
// eslint-disable-next-line no-console
15-
console.error(error)
16-
}
13+
// if (process.env.NODE_ENV === 'development') {
14+
// eslint-disable-next-line no-console
15+
console.error(error)
16+
// }
1717
const source = errorInfo.componentStack.split('\n')[1]
1818
trackErrorSpecify(
1919
source,

app/javascript/utils/trackError.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ export default function trackError(err, opts = {}) {
66
if (err && _.includes([401, 404], err.status)) {
77
return
88
}
9-
if (process.env.NODE_ENV === 'development') {
10-
console.error(err) // eslint-disable-line no-console
11-
}
9+
// if (process.env.NODE_ENV === 'development') {
10+
console.error(err) // eslint-disable-line no-console
11+
// }
1212
trackErrorSpecify(
1313
opts.source || 'Any',
1414
opts.message || err.message,

lefthook.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,9 @@ pre-commit:
44
commands:
55
lint:
66
files: git diff --name-only development
7-
glob: "*.js"
7+
glob: "*.{js,json}"
88
exclude: '__tests__/ui/grid/__snapshots__/*'
99
run: yarn run lint --fix {files}
10-
lint-json:
11-
files: git diff --name-only development
12-
glob: "*.json"
13-
run: yarn run lint --fix {files}
1410
rubocop:
1511
files: git diff --name-only development
1612
# exclude: "excluded_filename.rb"

0 commit comments

Comments
 (0)