add no-unreachable eslint rule

Author: niculistana

.eslintrc.js

@@ -7,7 +7,7 @@ module.exports = {
     'prettier',
     'import',
     'compat',
-    'json'
+    'json',
   ],
   env: {
     es6: true,
@@ -63,10 +63,10 @@ module.exports = {
       {
         argsIgnorePattern: '^_',
         args: 'none',
-        varsIgnorePattern: '^React$'
+        varsIgnorePattern: '^React$',
       },
     ],
-    'eqeqeq': ['error', 'smart'],
+    eqeqeq: ['error', 'smart'],
     'no-var': 'error',
     'prefer-const': 'error',
     'import/no-unresolved': 2,
@@ -84,6 +84,7 @@ module.exports = {
     'no-undef': 2,
     'no-duplicate-imports': 2,
     'no-console': ['warn', { allow: ['warn', 'error'] }],
+    'no-unreachable': 2,
     'object-shorthand': 1,
     'prettier/prettier': 'error',
     'prefer-destructuring': [

app/javascript/stores/ApiStore.js

@@ -776,7 +776,6 @@ class ApiStore extends jsonapi(datxCollection) {
     } catch (e) {
       // throw to be caught by CardMoveService
       throw e
-      return
     }
 
     runInAction(() => {
@@ -868,7 +867,6 @@ class ApiStore extends jsonapi(datxCollection) {
     } catch (e) {
       // throw to be caught by CardMoveService
       throw e
-      return
     }
     const collection = this.find('collections', data.to_id)
     const { meta } = res

app/javascript/ui/challenges/ChallengeHeaderButton.js

@@ -78,7 +78,6 @@ const ChallengeHeaderButton = ({ record, parentChallenge }) => {
   } else {
     return <ReviewSubmissionsButton record={record} />
   }
-  return null
 }
 
 ChallengeHeaderButton.propTypes = {

app/javascript/ui/challenges/PhaseSettings.js

@@ -74,8 +74,6 @@ const PhaseSettings = ({ collection, submissionBoxes, closeModal }) => {
         </TextButton>
       </Fragment>
     )
-
-    return null
   }
 
   const renderPhaseRows = submissionBox => {

app/javascript/ui/global/styled/buttons.js

@@ -215,5 +215,4 @@ const invertColor = color => {
     default:
       return v.colors.white
   }
-  return v.colors.white
 }

app/javascript/ui/grid/blankContentTool/CollectionCreator.js

@@ -70,16 +70,12 @@ class CollectionCreator extends React.Component {
     switch (type) {
       case 'submissionBox':
         return 'Collection::SubmissionBox'
-        break
       case 'testCollection':
         return 'Collection::TestCollection'
-        break
       case 'foamcoreBoard':
         return 'Collection::Board'
-        break
       case 'searchCollection':
         return 'Collection::SearchCollection'
-        break
       case 'collection':
       case 'template':
         return null

app/javascript/ui/pages/MarketingProductPage.js

@@ -91,7 +91,6 @@ class MarketingProductPage extends React.Component {
         break
       default:
         return ''
-        break
     }
 
     return (