Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix jsondata key in grafana_datasources variable #44

Open
ommarmol opened this issue May 15, 2024 · 0 comments
Open

[BUG] Fix jsondata key in grafana_datasources variable #44

ommarmol opened this issue May 15, 2024 · 0 comments
Labels

Comments

@ommarmol
Copy link
Member

ommarmol commented May 15, 2024

Description

The default variable grafana_datasources contains a typo using the key jsonData as can be seen here. The typo is also carried over to the jinja template used to process this variable.

This typo forces the use of the jsondata key when defining datasources, which could lead to errors when using official YAML configurations from Grafana.

Steps to Reproduce

  1. Define a datasource in the variable grafana_datasources containing the correct key jsonData.
  2. Use the role.

Expected behavior:
The role should create the datasource successfully.

Actual behavior:
The role crashes as the template datasource.json.j2 cannot find the key jsondata.

Reproduces how often:
Every time a datasource is defined containing the key jsonData.

Environment

  • The release version/s you are using: 2.0.0 of this role
  • OS: supported versions of Debian/Ubuntu

Additional Information

https://grafana.com/docs/grafana/latest/datasources/

@ommarmol ommarmol added the bug label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant