Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hit formatting of "complete geometry" input files #135

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

apb13
Copy link
Contributor

@apb13 apb13 commented Jun 27, 2024

Encountered input file runtime error with one out of two input files in this directory. We will rely on the syntax checking in CIVET to test this input file for continued functionality. Refs #131

Performed comparison between two csv files, one that was the original and another that received hit formatting, to ensure that the results were the same. Also ensured that comments were formatted correctly in the input file.
Refs #128

@moosebuild
Copy link

moosebuild commented Jul 2, 2024

Job Documentation on a197872 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Jul 2, 2024

Job Coverage on a197872 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on aadb385 : invalidated by @sapitts

@apb13 apb13 force-pushed the hit-complete_geometry_128 branch from aadb385 to a197872 Compare July 3, 2024 17:13
sapitts
sapitts previously approved these changes Jul 25, 2024
@moosebuild
Copy link

All jobs on a197872 : invalidated by @lindsayad

@moosebuild
Copy link

moosebuild commented Feb 19, 2025

Job Coverage, step generate coverage on 9fc47f1 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Feb 19, 2025

Job Documentation, step Sync to remote on 9fc47f1 wanted to post the following:

View the site here

This comment will be updated on new commits.

@lindsayad lindsayad force-pushed the hit-complete_geometry_128 branch from 7c58adb to 9fc47f1 Compare February 20, 2025 18:47
@lindsayad
Copy link
Member

@sapitts could you re-approve this? Looks like it just never got merged

@sapitts sapitts merged commit 7912ccb into idaholab:devel Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants