-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow strictly finding material components #663
Open
MicahGale
wants to merge
20
commits into
alpha-test-dev
Choose a base branch
from
mat_contains_strict
base: alpha-test-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+373
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolved |
MicahGale
commented
Feb 14, 2025
MicahGale
commented
Feb 14, 2025
MicahGale
commented
Feb 14, 2025
MicahGale
commented
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alpha testing
Issues that came up during alpha testing
feature request
An issue that improves the user interface.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This is a feature implementation for
contains
,get_containing
, andfind
. The topline is that there is a newstrict
argument that switches from implicit to explicit matching. So withstrict=True
"H"
only matches1000
and not1001.80c
nor1000.80c
. The other main thing was adding some feedback from @gonuke.This feedback splint
contains
(andget_containing
) to be:contains_all
andcontains_any
. This should be clearer to users, and be more useful. The main use case ofcontains_any
might be:Fixes #642
General Checklist
black
version 25.Documentation Checklist
For infrastructure updates, I have updated the developer's guide.First-Time Contributor Checklist
pyproject.toml
if you wish to do so.Additional Notes for Reviewers
Ensure that:
📚 Documentation preview 📚: https://montepy--663.org.readthedocs.build/en/663/