Update pre-commit config (#847)

* Update pre-commit

* Fix (or ignore) new pre-commit warnings

Author: mikeage

.pre-commit-config.yaml

@@ -1,22 +1,22 @@
 ---
 repos:
   - repo: https://github.com/adrienverge/yamllint.git
-    rev: v1.35.1
+    rev: v1.37.0
     hooks:
       - id: yamllint
   - repo: https://github.com/psf/black
-    rev: 24.3.0
+    rev: 25.1.0
     hooks:
       - id: black
         files: ^Support/
         language_version: python3
   - repo: https://github.com/pycqa/flake8
-    rev: 7.0.0
+    rev: 7.2.0
     hooks:
       - id: flake8
         files: ^Support/
   - repo: https://github.com/PyCQA/pylint.git
-    rev: v3.1.0
+    rev: v3.3.6
     hooks:
       - id: pylint
         name: pylint
@@ -28,7 +28,7 @@ repos:
           - --load-plugins=pylint.extensions.redefined_variable_type,pylint.extensions.bad_builtin
           - --disable=import-error
   - repo: https://github.com/google/yamlfmt
-    rev: v0.11.0
+    rev: v0.16.0
     hooks:
       - id: yamlfmt
         args:

Support/Python/unitybuild/utils.py

@@ -76,44 +76,44 @@ def msys_control_c_workaround():
     # abruptly ~100ms after the process receives SIGINT. This prevents us
     # from running cleanup handlers, like the one that kills the Unity.exe
     # subprocess.
-    if not os.getenv("MSYSTEM"):
-        return
-
-    kernel32 = ctypes.windll.kernel32
-    kernel32.GetStdHandle.restype = HANDLE
-    kernel32.GetStdHandle.argtypes = (DWORD,)
-    # kernel32.GetConsoleMode.restype = BOOL
-    kernel32.GetConsoleMode.argtypes = (HANDLE, ctypes.POINTER(DWORD))
-    # kernel32.SetConsoleMode.restype = BOOL
-    kernel32.SetConsoleMode.argtypes = (HANDLE, DWORD)
-    STD_INPUT_HANDLE = DWORD(-10)
-    ENABLE_PROCESSED_INPUT = DWORD(1)
-
-    stdin = kernel32.GetStdHandle(STD_INPUT_HANDLE)
-    mode = DWORD()
-    kernel32.GetConsoleMode(stdin, ctypes.byref(mode))
-    mode.value = mode.value & ~(ENABLE_PROCESSED_INPUT.value)
-    kernel32.SetConsoleMode(stdin, mode)
-
-    # interrupt_main won't interrupt WaitForSingleObject, so monkey-patch
-    def polling_wait(self):
-        while (
-            WaitForSingleObject(self._handle, 3000)  # pylint: disable=protected-access
-            != WAIT_OBJECT_0
-        ):
-            continue
-        return self.poll()
-
-    subprocess.Popen.wait = polling_wait
-
-    def look_for_control_c():
-        while msvcrt.getch() != "\x03":
-            continue
-        _thread.interrupt_main()
-
-    t = threading.Thread(target=look_for_control_c)
-    t.daemon = True
-    t.start()
+    if os.getenv("MSYSTEM"):
+        kernel32 = ctypes.windll.kernel32
+        kernel32.GetStdHandle.restype = HANDLE
+        kernel32.GetStdHandle.argtypes = (DWORD,)
+        # kernel32.GetConsoleMode.restype = BOOL
+        kernel32.GetConsoleMode.argtypes = (HANDLE, ctypes.POINTER(DWORD))
+        # kernel32.SetConsoleMode.restype = BOOL
+        kernel32.SetConsoleMode.argtypes = (HANDLE, DWORD)
+        STD_INPUT_HANDLE = DWORD(-10)
+        ENABLE_PROCESSED_INPUT = DWORD(1)
+
+        stdin = kernel32.GetStdHandle(STD_INPUT_HANDLE)
+        mode = DWORD()
+        kernel32.GetConsoleMode(stdin, ctypes.byref(mode))
+        mode.value = mode.value & ~(ENABLE_PROCESSED_INPUT.value)
+        kernel32.SetConsoleMode(stdin, mode)
+
+        # interrupt_main won't interrupt WaitForSingleObject, so monkey-patch
+        def polling_wait(self):
+            while (
+                WaitForSingleObject(
+                    self._handle, 3000  # pylint: disable=protected-access
+                )
+                != WAIT_OBJECT_0
+            ):
+                continue
+            return self.poll()
+
+        subprocess.Popen.wait = polling_wait
+
+        def look_for_control_c():
+            while msvcrt.getch() != "\x03":
+                continue
+            _thread.interrupt_main()
+
+        t = threading.Thread(target=look_for_control_c)
+        t.daemon = True
+        t.start()
 
 
 def get_file_version(filename):

Support/bin/animateTriangles.py

@@ -228,7 +228,7 @@ def animate(
 class Substroke:  # pylint: disable=too-many-instance-attributes
     def __init__(
         self, stroke, startVert, vertCount, startIndex, indexCount
-    ):  # pylint: disable=too-many-arguments
+    ):  # pylint: disable=too-many-arguments,too-many-positional-arguments
         self.stroke = stroke
         self.startVert = startVert
         self.vertCount = vertCount
@@ -343,7 +343,7 @@ def __init__(
         indexOffsets,
         indexCounts,
         displayOpacity,
-    ):  # pylint: disable=too-many-arguments
+    ):  # pylint: disable=too-many-arguments,too-many-positional-arguments
         self.dirty = True
         self.adj = 2 * random.random()
         self.prim = prim

Support/bin/tbdroid.py

@@ -110,7 +110,7 @@ def upload_sketch(sketchname):
 
 def profile_sketches(
     sketches, reps, csv, configtemplate, lod, skip
-):  # pylint: disable=too-many-arguments
+):  # pylint: disable=too-many-arguments,too-many-positional-arguments
     try:
         enable_powersaving(False)
         save_config()
@@ -263,7 +263,6 @@ def save_config():
 
 
 def restore_config():
-    global configcopy  # pylint: disable=global-statement,global-variable-not-assigned
     if configcopy:
         upload_config(configcopy)
     else: