nomenclature

martinunland · martinunland · commit a304ee06aeda · 2024-06-11T15:26:05.000+02:00
diff --git a/common/framework/src/OMSimDataFileTypes.cc b/common/framework/src/OMSimDataFileTypes.cc
@@ -1,6 +1,3 @@
-/**
- * @todo Check ReflectiveSurface::extractInformation(), code look suspicious.
- */
 #include "OMSimDataFileTypes.hh"
 #include "OMSimInputData.hh"
 #include "OMSimLogger.hh"
diff --git a/common/geometry_construction/include/OMSimDEGG.hh b/common/geometry_construction/include/OMSimDEGG.hh
@@ -1,7 +1,6 @@
 /**
  * @file OMSimDEGG.hh
- * @brief Construction of the DEGG class.
- * @author Geometry from DOUMEKI parsed by Berit Schlüter
+ * @brief Construction of the DEGG class. From DOUMEKI
  * @ingroup common
  */
 
diff --git a/common/geometry_construction/include/OMSimLOM16.hh b/common/geometry_construction/include/OMSimLOM16.hh
@@ -1,7 +1,5 @@
 /** @file OMSimLOM16.hh
  *  @brief Construction of LOM16.
- *
- *  @author Javi Vara & Markus Dittmer
  *  @ingroup common
  */
 
diff --git a/common/geometry_construction/include/OMSimLOM18.hh b/common/geometry_construction/include/OMSimLOM18.hh
@@ -1,7 +1,5 @@
 /** @file OMSimLOM18.hh
  *  @brief Construction of LOM18.
- *
- *  @author Javi Vara & Markus Dittmer
  *  @ingroup common
  */
 #ifndef OMSimLOM18_h
diff --git a/common/geometry_construction/include/OMSimMDOMFlasher.hh b/common/geometry_construction/include/OMSimMDOMFlasher.hh
@@ -7,8 +7,6 @@
  * mDOMFlasher is responsible for creating the flashers in the mDOM, which includes a LED, 
  * the air around it, and a glass window on top. The class provides functionalities for constructing 
  * the solids and logical volumes, retrieving them, and simulating the LED flashing based on a given profile.
- *
- * @author Anna-Sophia Tenbruck, Cristian Lozano, Martin Unland
  * @ingroup common
  */
 
diff --git a/common/geometry_construction/src/abcDetectorComponent.cc b/common/geometry_construction/src/abcDetectorComponent.cc
@@ -181,21 +181,21 @@ G4SubtractionSolid *abcDetectorComponent::substractToVolume(G4VSolid *pInputVolu
 {
     G4SubtractionSolid *lSubstractedVolume;
     G4Transform3D lTrans;
-    G4int iCounter = 0;
+    G4int lCounter = 0;
     for (auto const &[key, Component] : mComponents)
     {
         lTrans = getNewPosition(pSubstractionPos, pSubstractionRot, Component.Position, Component.Rotation);
         G4String mssg = "Substracting " + key + " from " + pInputVolume->GetName() + ".";
         log_debug(mssg);
-        if (iCounter == 0)
+        if (lCounter == 0)
         {
             lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", pInputVolume, Component.VSolid, lTrans);
         }
         else
         {
             lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", lSubstractedVolume, Component.VSolid, lTrans);
         }
-        iCounter++;
+        lCounter++;
     }
     return lSubstractedVolume;
 }
@@ -213,20 +213,20 @@ G4SubtractionSolid *abcDetectorComponent::substractToVolume(G4VSolid *pInputVolu
 G4SubtractionSolid *abcDetectorComponent::substractToVolume(G4VSolid *pInputVolume, G4Transform3D pTrans, G4String pNewVolumeName)
 {
     G4SubtractionSolid *lSubstractedVolume;
-    G4int iCounter = 0;
+    G4int lCounter = 0;
     for (auto const &[key, Component] : mComponents)
     {
         G4String mssg = "Substracting " + key + " from " + pInputVolume->GetName() + ".";
         log_debug(mssg);
-        if (iCounter == 0)
+        if (lCounter == 0)
         {
             lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", pInputVolume, Component.VSolid, pTrans);
         }
         else
         {
             lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", lSubstractedVolume, Component.VSolid, pTrans);
         }
-        iCounter++;
+        lCounter++;
     }
     return lSubstractedVolume;
 }
diff --git a/supernova/include/OMSimSNParticleGenerators.hh b/supernova/include/OMSimSNParticleGenerators.hh
@@ -1,7 +1,6 @@
 /**
  * @file 
  * @brief This file contains the classes in charge of particle generation 
- * @author Cristian Jesus Lozano Mariscal
  * @ingroup sngroup
  */
 
diff --git a/supernova/include/OMSimSNTools.hh b/supernova/include/OMSimSNTools.hh
@@ -4,8 +4,6 @@
  * 
  * This class serves as a central utility to house common methods needed in the generation 
  * of SN neutrino interactions.
- *
- * @author Cristian Jesus Lozano Mariscal
  * @ingroup sngroup
  */
 
diff --git a/supernova/src/OMSimPrimaryGeneratorMessenger.cc b/supernova/src/OMSimPrimaryGeneratorMessenger.cc
@@ -1,7 +1,5 @@
 /** @file OMSimPrimaryGeneratorMessenger.cc
  *  @brief Primary generator messenger to choose the corresponding primary generator.
- * 
- *  @author Cristian Jesus Lozano Mariscal
  */
 
 #include "OMSimPrimaryGeneratorMessenger.hh"
diff --git a/supernova/src/OMSimSNAnalysis.cc b/supernova/src/OMSimSNAnalysis.cc
@@ -1,7 +1,5 @@
 /** @file OMSimSNAnalysis.cc
  *  @brief Analyze data and write output files
- * 
- *  @author Cristian Jesus Lozano Mariscal
  */
 
 #include "OMSimSNAnalysis.hh"
diff --git a/trash/OMSimIBD.hh~~ b/trash/OMSimIBD.hh~~
@@ -1,9 +1,6 @@
 /**
  * @file OMSimIBD.hh
  * @brief This file contains the class in charge of generating positrons from IBD of supernova antineutrino interactions
- *
- * @author Cristian Jesus Lozano Mariscal
- * @version 10.1
  * @ingroup SN
  */
 
diff --git a/trash/OMSimPrimaryGeneratorAction.ccold b/trash/OMSimPrimaryGeneratorAction.ccold
@@ -1,7 +1,5 @@
 /** @file OMSimPrimaryGeneratorAction.cc
  *  @brief Main primary generator. Chooses between generators 0 (IBD), 1 (ENES), 2 (SN ibd)
- * 
- *  @author Cristian Jesus Lozano Mariscal
  */
 
 #include "OMSimPrimaryGeneratorAction.hh"

Original file line number	Diff line number	Diff line change
`@@ -181,21 +181,21 @@ G4SubtractionSolid abcDetectorComponent::substractToVolume(G4VSolid pInputVolu`
`181`	`181`	`{`
`182`	`182`	`G4SubtractionSolid *lSubstractedVolume;`
`183`	`183`	`G4Transform3D lTrans;`
`184`		`- G4int iCounter = 0;`
	`184`	`+ G4int lCounter = 0;`
`185`	`185`	`for (auto const &[key, Component] : mComponents)`
`186`	`186`	`{`
`187`	`187`	`lTrans = getNewPosition(pSubstractionPos, pSubstractionRot, Component.Position, Component.Rotation);`
`188`	`188`	`G4String mssg = "Substracting " + key + " from " + pInputVolume->GetName() + ".";`
`189`	`189`	`log_debug(mssg);`
`190`		`- if (iCounter == 0)`
	`190`	`+ if (lCounter == 0)`
`191`	`191`	`{`
`192`	`192`	`lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", pInputVolume, Component.VSolid, lTrans);`
`193`	`193`	`}`
`194`	`194`	`else`
`195`	`195`	`{`
`196`	`196`	`lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", lSubstractedVolume, Component.VSolid, lTrans);`
`197`	`197`	`}`
`198`		`- iCounter++;`
	`198`	`+ lCounter++;`
`199`	`199`	`}`
`200`	`200`	`return lSubstractedVolume;`
`201`	`201`	`}`
`@@ -213,20 +213,20 @@ G4SubtractionSolid abcDetectorComponent::substractToVolume(G4VSolid pInputVolu`
`213`	`213`	`G4SubtractionSolid abcDetectorComponent::substractToVolume(G4VSolid pInputVolume, G4Transform3D pTrans, G4String pNewVolumeName)`
`214`	`214`	`{`
`215`	`215`	`G4SubtractionSolid *lSubstractedVolume;`
`216`		`- G4int iCounter = 0;`
	`216`	`+ G4int lCounter = 0;`
`217`	`217`	`for (auto const &[key, Component] : mComponents)`
`218`	`218`	`{`
`219`	`219`	`G4String mssg = "Substracting " + key + " from " + pInputVolume->GetName() + ".";`
`220`	`220`	`log_debug(mssg);`
`221`		`- if (iCounter == 0)`
	`221`	`+ if (lCounter == 0)`
`222`	`222`	`{`
`223`	`223`	`lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", pInputVolume, Component.VSolid, pTrans);`
`224`	`224`	`}`
`225`	`225`	`else`
`226`	`226`	`{`
`227`	`227`	`lSubstractedVolume = new G4SubtractionSolid("SubstractedVolume", lSubstractedVolume, Component.VSolid, pTrans);`
`228`	`228`	`}`
`229`		`- iCounter++;`
	`229`	`+ lCounter++;`
`230`	`230`	`}`
`231`	`231`	`return lSubstractedVolume;`
`232`	`232`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,6 @@`
`4`	`4`	`*`
`5`	`5`	`* This class serves as a central utility to house common methods needed in the generation`
`6`	`6`	`* of SN neutrino interactions.`
`7`		`- *`
`8`		`- * @author Cristian Jesus Lozano Mariscal`
`9`	`7`	`* @ingroup sngroup`
`10`	`8`	`*/`
`11`	`9`