-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: add_operation
attempts to call into removed translator_class
#9158
Comments
Hey @DavidSlayback -- looks like we forgot to update how |
Hey @DavidSlayback -- I forgot, we added built-in support for
e.g. [ins] In [1]: import ibis
[ins] In [2]: t = ibis.memtable({"b": [1, 2]})
[ins] In [3]: ibis.to_sql(t.b.try_cast("float64"), dialect="bigquery")
Out[3]:
SELECT
SAFE_CAST(`t0`.`b` AS FLOAT64) AS `TryCast_b_ Float64`
FROM `ibis_pandas_memtable_cywg4g55dbgethukk5btbdeyve` AS `t0` |
add_operation
attempt to call into removed translator_class
add_operation
attempt to call into removed translator_class
add_operation
attempts to call into removed translator_class
Thank you! Both for pointing to existing functionality and for considering a fix next release. Overall we get a ton of use out of this project, thanks for building it 😀 |
What happened?
Previously (under Ibis 7.2.0), we had defined a
SAFE_CAST
operation for our usage of Ibis with bigquery with the following:When attempting to update to Ibis 9.0.0, this broke with the error:
AttributeError: 'BigQueryCompiler' object has no attribute 'translator_class'
Not sure if this is a bug or an intended change in the way a user can add an operation to Ibis
What version of ibis are you using?
7.2.0 originally, 9.0.0 for the error
What backend(s) are you using, if any?
BigQuery
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: