We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems when placement is changed conflict hander is never called and incoming change replaces local change.
In this case locally deleted element pop back up during rebase.
To Reproduce Steps to reproduce the behavior:
Here is a test and branch is set that have following test.
it.only("delete instance (data conflict) ", async () => { const b1 = await ctx.openB1(true /* = noLock */); const b2 = await ctx.openB2(true /* = noLock */); const e1 = await insertPhysicalObject(b1); b1.saveChanges(); await b1.pushChanges({ description: `inserted physical object [id=${e1}]` }); await b2.pullChanges(); const eb1 = b1.elements.getElementProps<PhysicalElementProps>(e1); eb1.userLabel = "test1"; eb1.placement = { origin: { x: 1, y: 1, z: 1 }, angles: { yaw: 1, pitch: 1, roll: 1 } }; b1.elements.updateElement(eb1); b1.saveChanges(); await b1.pushChanges({ description: `update physical object [id=${e1}]` }); b2.elements.deleteElement(e1);; b2.saveChanges(); await b2.pullChanges(); const eb2 = b2.elements.tryGetElementProps<PhysicalElementProps>(e1); // should throw assert.isUndefined(eb2); b1.close(); b2.close(); });
Expected behavior The element should stay deleted.
reported by : @wgoehrig
The text was updated successfully, but these errors were encountered:
When branches are created from issues, their pull requests are automatically linked.
It seems when placement is changed conflict hander is never called and incoming change replaces local change.
In this case locally deleted element pop back up during rebase.
To Reproduce
Steps to reproduce the behavior:
Here is a test and branch is set that have following test.
Expected behavior
The element should stay deleted.
reported by : @wgoehrig
The text was updated successfully, but these errors were encountered: