Measurable doesn't mark complete

[Lissidragon]

Pre-submission checklist

• [ y] I am submitting a bug report, not a feature request.
• [y ] I have searched for similar issues, but did not find any matches. (There was one feature request but didn't seem exact match)

Description

I created a measurable task to clean the office 60 mins every month. No matter how many times I put in 60 mins, the task isn't marked completed so it doesn't hide.

Steps to reproduce

1. Create a new measurable task.
2. Set units to mins. Set target to 60. Set frequency to month.
3. Go to Calendar or Main view to set several days to 60.
4. Return to main view if not there already.
5. Note that task does not hide upon completing 60mins within a months time.

System information

• Phone: Google Pixel 4
• Phone Operating System: Android 11
• App version: 2.0.3

Screenshots

screenshots

[sgallese]

@Lissidragon if you click the filter option, do you have "Hide completed" checked? When I have this option checked, the task is hidden for me once I complete the task.

[Lissidragon]

This "Test" is a monthly with 60min as target. See that hide completed is on and the task is still there despite 60min being done 3 days ago. (I toggled the hide but it still didn't go away)

[sgallese]

This is helpful, @Lissidragon, thank you for the extra context.
I'm new to this project, and I think you've raised an interesting point.

The hide completed filter will hide a habit if it is completed today or failed today.

In this case, for a measurable habit, I'm not sure if the failed today logic makes sense for the filter.
For example, let's say I need to clean my office 60 minutes a day.
If I clean it 60 minutes today, the habit will be completed.
If I only clean it 20 minutes (or 0 minutes), then the habit is failed (PR).
Thus, if the hide completed filter is enabled, this matcher will always return false and will always hide the habit.

To make things more interesting, the hide completed logic only works for items completed today.
In this case of our current issue, we have a habit that has a frequency of each month.
One might expect, as @Lissidragon does, that the habit should be hidden if they completed this habit prior to today.
In this case, maybe the correct approach is to check if the habit has been completed (or failed) within the frequency set.
For example, if the user sets the habit frequency to one week.
If the habit has been completed (or failed) within the last week, hide the habit.
Otherwise, show the habit.

[hiqua]

The problem seems to be that we handle yes/no habits differently from measurable ones. From memory:

• Yes / no: we compute whether the current goal means that it's completed for today (even if it's not been checked explicitly today)
• Interval: we just check today's value, meaning that we will only hide it if you reached the number today, independently from what you did the past few days

[pfertyk]

Hi! Is there any update on this issue? I can see a milestone attached, is there a planned release date? :)

Let me also add that this tool is really amazing and looks and feels very professional! That's why I was surprised to find out that measurable habits are never marked as completed :D For now, I just ignore the habit when I know that I'm done with it for the week, but it would be fantastic to have it marked as done in the calendar view as well ;)

[marcoebbinghaus]

Hi, I would like to contribute a fix for that. Is anybody already working on this?

[hiqua]

@marcoebbinghaus no, go ahead!

[SimonDedman]

I believe this is the same issue but just confirming: habits with a weekly target don't highlight in the widget once the target has been exceeded.
For days (like these) when the habit has been done, but the weekly target not exceeded, I feel like this solution would be a nice fix.

Thanks for a brilliant app, it's been genuinely lifechanging!

[iSoron]

Loop doesn't currently mark non-daily numerical habits as completed. Moving to discussions as this is a missing feature, not some behavior that is unexpected to the developers.

[GeorgeD88]

I see. I really love this app and have been using it for a few years. I was very curious about how weekly tracking works for numerical habits as it didn't seem to make sense. I'm very interested in contributing to open source projects and decided to check out the repo and saw that there seems to already be some discussion around this logic. Could you update me with what's been going on with this idea? Have there been any changes or ideas for development?

I'd really love to hop into the loop for this missing feature/bug!

[iSoron]

Hi @GeorgeD88, a PR fixing this would be very welcome.

[GeorgeD88]

I'm unsure how to approach solving it though, but I'd love to be involved in helping solve it. Actually I was wondering, since there's no current way to mark numerical habits over days as completed, how is it computed when you open to see how many days the habit has been unbroken for? If I could have any of the logic for determining the habit as complete, that would really help in working towards a solution. Thank you!