Skip to content

Commit a4d7769

Browse files
committed
fix redirect leak
1 parent 944d73e commit a4d7769

File tree

5 files changed

+8
-12
lines changed

5 files changed

+8
-12
lines changed

Dokcer

Whitespace-only changes.

src/main.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,13 @@ bool check_valid_line(char *str)
4848
static void minishill_start(t_minishell *msh, char **env)
4949
{
5050
msh->env_table = init_table(env);
51-
//print_hash(msh->env_table);
52-
//printf("%s",msh->env[0]);
5351
while (1)
5452
{
53+
if (msh->line)
54+
{
55+
free(msh->line);
56+
ft_command_table_free(msh);
57+
}
5558
read_line(msh);
5659
if (ft_strlen(msh->line) == 0)
5760
{
@@ -63,11 +66,6 @@ static void minishill_start(t_minishell *msh, char **env)
6366
if (!ft_tokenizer(msh))
6467
continue ;
6568
init_execute(msh);
66-
if (msh->line)
67-
{
68-
free(msh->line);
69-
ft_command_table_free(msh);
70-
}
7169
}
7270
}
7371

src/tools/tokenizer/tokenizer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ void init_command_table(t_minishell *msh)
7171
int i;
7272

7373
i = 0;
74-
ft_check_quotes(msh); // ;eak in this function 🙄
74+
ft_check_quotes(msh);
7575
add_space_redirect_char(msh);
7676
tmp = tk_split_pip(msh);
7777
count_pipe = 0;

src/tools/tokenizer/tokenizer_tools.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/* By: Dokcer <[email protected]> +#+ +:+ +#+ */
77
/* +#+#+#+#+#+ +#+ */
88
/* Created: 2022/06/22 04:59:25 by oal-tena #+# #+# */
9-
/* Updated: 2022/07/13 13:58:43 by Dokcer ### ########.fr */
9+
/* Updated: 2022/07/24 06:27:05 by Dokcer ### ########.fr */
1010
/* */
1111
/* ************************************************************************** */
1212

src/utils/ft_free.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/* By: Dokcer <[email protected]> +#+ +:+ +#+ */
77
/* +#+#+#+#+#+ +#+ */
88
/* Created: 2022/04/24 12:39:16 by oal-tena #+# #+# */
9-
/* Updated: 2022/07/23 10:16:08 by Dokcer ### ########.fr */
9+
/* Updated: 2022/07/24 06:05:35 by Dokcer ### ########.fr */
1010
/* */
1111
/* ************************************************************************** */
1212

@@ -109,13 +109,11 @@ void ft_command_table_free(t_minishell *msh)
109109
free_2d_array(msh->cmd_table[i]->cmd);
110110
if (msh->cmd_table[i]->filename)
111111
free_2d_array(msh->cmd_table[i]->filename);
112-
//free(msh->cmd_table[i]->filename);
113112
free_token(msh->cmd_table[i]);
114113
free(msh->cmd_table[i]->exec_table);
115114
free(msh->cmd_table[i]);
116115
i++;
117116
}
118-
//free_2d_array(msh->env);
119117
free_quotes(msh);
120118
free(msh->cmd_table);
121119
}

0 commit comments

Comments
 (0)