-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPC-H Benchmark: item run limitation does not work in suffled mode #2389
Comments
Or is it actually expected behavior? |
I would definitely say no. I am not even sure if we have ever considered using |
Even if it would be, the documentation would be wrong: Maximum number of runs per item
This issue is independent of multiple clients but an issue of shuffled, isn't it? |
Right |
Yes, but not counting it as runs per client doesn’t make sense imo. |
What about not supporting runs when the shuffled mode is used? Simply an assert and a message such as |
And while we're at it: we could change the following output for shuffled runs |
Sounds good to me. |
Executing the TPC-H benchmark in shuffled mode (
-m Shuffled
) with a runs-per-item limitation ofx
and a time limit that is high enough so that the query can be executed x times results in an incorrect number of executions.Steps to Reproduce
Execute
./hyriseBenchmarkTPCH -t 9999999 -r 10 -m Shuffled -s 1 -o output.json
Expected Behavior
Each query item is executed 10 times.
Actual Behavior
The total number of query item executions is 10. Each item is executed at most once. With a higher runs-per-item limitation, the number of runs per item can also be higher.
Log (click to expand)
JSON output: output.json.log
Build Information
CMake command
LLVM
The text was updated successfully, but these errors were encountered: