Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: core: more hyprutils smart pointer usage and safe reference to widgets #686

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PaideiaDilemma
Copy link
Collaborator

@PaideiaDilemma PaideiaDilemma commented Feb 12, 2025

Closes #684

@PaideiaDilemma
Copy link
Collaborator Author

I couldn't hold myself and renamed a bunch of stuff making this way to big.
Will undo the renaming and then move it out of draft.

Maybe we should get that before 0.7.0.

Stuff I am not that happy with yet:

  • registerSelf can't be virtual, but we need m_self to safely create a ref to the current widget.
  • using lambdas for the callbacks kind of makes the static handler methods in the widgets redundant. Perhaps removing them and just calling the widgets methods in the lambda directly is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unplugging/Removing an output may result in dangling pointers
1 participant