Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set the image size as a percentage #555

Open
kamack38 opened this issue Nov 12, 2024 · 7 comments · May be fixed by #591
Open

Add the ability to set the image size as a percentage #555

kamack38 opened this issue Nov 12, 2024 · 7 comments · May be fixed by #591
Labels
enhancement New feature or request

Comments

@kamack38
Copy link

Description

Currently, only shape size can be set by a percentage and image sizes can't.

@kamack38 kamack38 added the enhancement New feature or request label Nov 12, 2024
@PaideiaDilemma
Copy link
Collaborator

Yup already planned :)

@kamack38
Copy link
Author

Have you thought about allowing percentage floats? I've been playing with the new units and I found myself missing the ability to use e.g. 43.21%.

@PaideiaDilemma
Copy link
Collaborator

what option are you talking about?

@kamack38
Copy link
Author

Currently, I can only set the position using integer percentages e.g. 1%, 5%, 8% and not floating point percentages e.g. 1.2% 0.3% 20.22%.

@PaideiaDilemma
Copy link
Collaborator

You are right. Maybe we want to change the current implementation to just take floats instead of just integers.

@PaideiaDilemma
Copy link
Collaborator

Currently, I can only set the position using integer percentages e.g. 1%, 5%, 8% and not floating point percentages e.g. 1.2% 0.3% 20.22%.

@kamack38 Actually that already works :)

@PaideiaDilemma
Copy link
Collaborator

@kamack38 I ditched the idea with pt and instead added a sizex option. Can you maybe checkout the PR I linked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants