-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't hyprpm update #6232
Comments
If you're using hyprland from the official Arch repo, then you can do something like this: cd ~/.local/share/hyprpm/headersRoot
rm -rf include/hyprland
rm share/pkgconfig/hyprland.pc
ln -sf /usr/include/hyprland include/hyprland
ln -sf /usr/share/pkgconfig/hyprland.pc share/hyprland.pc Hyprpm stopped using system provided hyprland headers because it caused some issues with some distributions, but in Arch the hyprland package provides correct header files, so there's no need to clone them from git. This creates symlinks back to the system provided hyprland headers. |
BTW, before you try the solution from my previous comment, can you try running hyprpm like this? LANG=C hyprpm update -v |
We're working on it #6181. |
Can you update hyprland and try again? I've just merged the fix. |
1st try
Shel returned :$ LANG=C hyprpm update -v[v] version returned: Hyprland, built from branch at commit cba1ade (props: bump version to 0.40.0). flags: (if any) [v] parsed commit cba1ade at branch on Sat May 4 15:42:32 2024, commits 4606 ╍━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0 / 5 Cloning the hyprland re! Cloning https://github.com/hyprwm/hyprland, this might take a moment. ✔ cloned [v] git returned (rs): rm 'subprojects/tracy' ✔ checked out to running ver [v] meson returned: The Meson build system wlroots 0.18.0-dev
User defined options Found ninja-1.12.1 at /usr/bin/ninja ✔ configured Hyprland ✖ failed to install headers with error code 2 ✖ Headers missing. Please run hyprpm update to fix those. 2nd try
Didn't work 3rd try
I |
I'm using hyprland stable on Arch and I have no issues with hyprpm (I use hy3 installed via hyprpm). Maybe you're missing some build dependencies in your system. I see you don't have cmake installed. Maybe try installing it and try again? |
(french)
No, didn't work. Boohoohoo
$ sudo pacman -S cmake résolution des dépendances… Paquets (3) cppdap-1.58.0-1 rhash-1.4.4-1 cmake-3.29.3-1 Taille totale installée : 75,10 MiB :: Procéder à l’installation ? [O/n] O ! Cloning https://github.com/hyprwm/hyprland, this might take a moment. |
Try again with
Last time it helped go further (even though it still failed afterwards). It seems that having git command output messages in French (or rather non-English) may not be what hyprpm expects. |
I think the issue is with this line: Hyprland/hyprpm/src/core/PluginManager.cpp Line 450 in db5d39a
The I think this should be called using The second issue is setting the So with both changes, this should look like this: const std::string SHALLOW_DATE =
removeBeginEndSpacesTabs(HLVER.date).empty() ? "" : execAndGet("env LC_TIME=C date --date='" + HLVER.date + " - 1 weeks' '+\%a \%b \%d \%H:\%M:\%S \%Y'"); |
Continuing on my last comment, I think there's not even a need for using date command to get timestamp for shallow clone. Since version 2.20.1, git supports relative date definition for
Git 2.20.1 came out 6 years ago, so I think it's rather safe to assume that everyone using hyprland already have a newer version. Anyway is there a specific reason why the clone is shallowed since 1 week in the past? Can't hyprpm just use |
we need 1 week before a set timestamp, not 1 week before whenever the command is ran |
Ah, yes. That makes more sense. Anyway, setting |
MRs welcome |
Ok, I don't think any changes are necessary in the end. I've just tried hyprpm update from git main and it seems that setting environment variable like that works ok. So I'm sorry for saying it's a bug as it clearly is not. I was in the wrong here. I'd still change locale from |
Same issue here on nixos |
same issue on manjaro, not on arch though strangely enough, works fine on arch |
seems to just be a out of date package in the manjaro repos, the git version seems to work just fine |
I think I need to wait for the next stable release and see what appends. Also, I installed the en_US.UTF-8 stuff but still doesn't work. |
I figured out my problem, the extra repos in arch don't have an essential package as a depend for some reason, I think it's called hyprwayland-scanner, and I tried to tell the repo maintainer that it was missing depends, but had issues making an account for some reason |
from 0.41.0 hyprpm should print out missing packages |
To be honest, hyprwayland-scanner is a build dependency. If someone doesn't use hyprpm then that package is not needed at all. I think that (at least in ArchLinux) it would be better to package hyprpm separately from hyprland and add hyprwayland-scanner as a dependency to that package. Unfortunately I don't have an account on ArchLinux's GitLab to suggest that and they've disabled registration because of a lot of spam. |
I whole heartedly disagree, hyprpm is the only official way to get plugins into hyprland, which imo is an integral feature, without plugins hyprland is barley a DE, and especially without hy3 considering there's no obvious way to change the looks of the normal tabs for groups, but I would agree that if hyprwayland-scanner doesn't come with the package then hyprpm should at least be packaged separately with its own depends. In either case there's a package in the arch repos that is not functional because of missing depends, hopefully one of us gets an account soon to be able to at least tell them that |
I've requested an account and got one already. I've reported the issue. I fully agree that the hyprpm is an integral part of the hyprland. But I don't think 100% of hyprland and ArchLinux users use addons for sure or use hyprpm for them (they may choose to go with unsupported AUR route for example). Adding hyprwayland-scanner as a dependency to hyprland would add unnecessary dependency for anyone who doesn't use hyprpm. BTW I symlink Arch package provided hyprland headers to |
BTW here's the issue I've created in Arch's GitLab: I've also linked it back to this issue. |
@vaxerski is there a reason hyprpm doesn't just use the installed hyprland headers? (Can easily be found with pkgconfig) |
Isn't it because issues with some distributions, which ship outdated headers or no headers at all? One issue I see with system provided headers (even in Arch, which seems to be ok in other circumstances): |
There can be an option that doesn't reload plugins if the headers version and the running Hyprland version doesn't match. For greater control we can add a |
distro headers are unreliable, thats why. They can also be incorrectly user-supplied (they once built hl manually and installed the headers) |
Understandable, even though as a packager that's a nightmare. |
feel free to patch hyprpm :) |
if the system doesn't have X at all then Hyprland builds/installs fine and
|
patch how? revert to using system headers? |
unreliable how?
some users supplied wrong headers? i don't think that should be the deciding factor here. |
headers are ignored by upstream! see [1] [1] hyprwm/Hyprland#6232
|
Don't know why, but now it works. I anyone has the same problem, I think it's better to open a new issue |
Hyprland Version
System/Version info
Bug or Regression?
Regression
Description
Can't
hyprpm update
:How to reproduce
Type the
hyprpm update
command, on hyprland stable arch, withhyprland-plugins
Crash reports, logs, images, videos
I did all my
yay -Syu
andsudo pacman -Syu
The text was updated successfully, but these errors were encountered: