Latest Git won't build: unrecognized command-line option ‘-Wno-gnu-zero-variadic-macro-arguments’

[tannerellen]

Latest git won't build and is now giving an error with an unrecognid argument.

cc1plus: note: unrecognized command-line option ‘-Wno-gnu-zero-variadic-macro-arguments’ may have been intended to silence earlier diagnostics [431/662] Building CXX object CMakeFiles/Hyprland.dir/src/config/ConfigManager.cpp.o ninja: build stopped: subcommand failed. ==> ERROR: A failure occurred in build(). Aborting... error: failed to build 'hyprland-git-0.52.0.r0.gf56ec18-1':

I believe this started after: 2cb0f02 as I built prior to that without issues.

[tannerellen]

I tried building manually and it worked so I thought this wasn't an issue anymore but I missed that I was still on an old branch. So this is indeed an issue with the latest commit. Looks like there is more than one error.

[rewqoijp3456]

From the build logs for 2cb0f02 on, it looks like the unescaped quotes in the commit message are what is actually causing the error:

[ 27%] Building CXX object CMakeFiles/Hyprland.dir/src/debug/HyprCtl.cpp.o
In file included from /__w/Hyprland/Hyprland/src/debug/HyprCtl.cpp:48:
/__w/Hyprland/Hyprland/src/debug/../version.h:4:88: error: stray ‘#’ in program
4 | #define GIT_COMMIT_MESSAGE "dwindle: Revert "rework split logic to be fully gap-aware (#12047)""
| ^
/__w/Hyprland/Hyprland/src/debug/HyprCtl.cpp:1051:27: note: in expansion of macro ‘GIT_COMMIT_MESSAGE’
1051 | auto commitMsg = trim(GIT_COMMIT_MESSAGE);
| ^~~~~~~~~~~~~~~~~~
[ 27%] Building CXX object CMakeFiles/Hyprland.dir/src/debug/HyprDebugOverlay.cpp.o
/__w/Hyprland/Hyprland/src/debug/HyprCtl.cpp: In function ‘std::string versionRequest(eHyprCtlOutputFormat, std::string)’:
/__w/Hyprland/Hyprland/src/debug/../version.h:4:28: error: unable to find string literal operator ‘operator""rework’ with ‘const char [17]’, ‘long unsigned int’ arguments
4 | #define GIT_COMMIT_MESSAGE "dwindle: Revert "rework split logic to be fully gap-aware (#12047)""
| ^~~~~~~~~~~~~~~~~~~~~~~~
/__w/Hyprland/Hyprland/src/debug/HyprCtl.cpp:1051:27: note: in expansion of macro ‘GIT_COMMIT_MESSAGE’
1051 | auto commitMsg = trim(GIT_COMMIT_MESSAGE);
| ^~~~~~~~~~~~~~~~~~
[ 29%] Building CXX object hyprtester/CMakeFiles/hyprtester.dir/src/tests/main/persistent.cpp.o
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-gnu-zero-variadic-macro-arguments’ may have been intended to silence earlier diagnostics
make[3]: *** [CMakeFiles/Hyprland.dir/build.make:569: CMakeFiles/Hyprland.dir/src/debug/HyprCtl.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....

[vaxerski]

blame @fufexan

[tannerellen]

I have recorded the appropriate blame that will go out in the quarterly reports. Also since the issue is resolved now I'll close the discussion.

Thanks for getting that resolved so quick.

[fufexan]

Should no longer happen from e15409b onwards.