v0.52.0 parses windowrule slightly differently and slightly breaks regex parsing that previously worked

[sk4rrjin]

Before v0.52.0 this windowrule regex worked fine:
windowrule = tag +pip, title:(Picture.{0,1}in.{0,1}[Pp]icture)

In v0.52.0 it throws "Invalid rule" and "Invalid parameter" errors. Changing the regex very slightly fixes the error:
windowrule = tag +pip, title:(Picture.?in.?[Pp]icture)

However, .{0,1} is a valid occurrence regex, so it seems this breaking change and errors thrown were not intentional.

(Popped up in omarchy 3.1.6 basecamp/omarchy#3254)

[vaxerski]

potentially the comma?

[DaBuddhalint]

yeah .52 seems to have changed parsing a bit. as per RE2's Syntax Rules it should be correct.

[vaxerski]

what I am saying is that maybe the comma is treated as a delimiter, cutting off the regex. Try a regex without commas

[DaBuddhalint]

yeah, all i'm saying it's just weird

[Dregu]

Add that to the list of things that need a way to escape commas in hyprlang/cvarlist parsing...

[vaxerski]

hyprwm/hyprutils#84 for escaping

[vaxerski]

84 got merged, this will be fixed in 0.53, as I don't want to introduce a potentially breaking change in a patch release.

[vaxerski]

#12249

[Brumus14]

Does windowrule = tag +pip, match:title Picture.{0\,1}in.{0\,1}[Pp]icture not work to escape the commas as window rule already uses CVarList2 so it should be able to escape delimiter?

[vaxerski]

well new window rules are only in git but yes that should work, or you could use the expanded window rule syntax and no escapes are needed