Non-resizeable GLFW window shrinks into oblivion

[zacoons]

#include <iostream>

// GLEW
#define GLEW_STATIC
#include <GL/glew.h>

// GLFW
#include <GLFW/glfw3.h>

// Window dimensions
const GLuint WIDTH = 800, HEIGHT = 600;

// Shaders
const GLchar* vertexShaderSource = "#version 330 core\n"
    "layout (location = 0) in vec3 position;\n"
    "void main()\n"
    "{\n"
    "gl_Position = vec4(position.x, position.y, position.z, 1.0);\n"
    "}\0";
const GLchar* fragmentShaderSource = "#version 330 core\n"
    "out vec4 color;\n"
    "void main()\n"
    "{\n"
    "color = vec4(1.0f, 0.5f, 0.2f, 1.0f);\n"
    "}\n\0";

// The MAIN function, from here we start the application and run the game loop
int main()
{
    // Init GLFW
    glfwInit();
    // Set all the required options for GLFW
    glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
    glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3);
    glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);
    glfwWindowHint(GLFW_RESIZABLE, GL_FALSE);

    // Create a GLFWwindow object that we can use for GLFW's functions
    GLFWwindow* window = glfwCreateWindow(WIDTH, HEIGHT, "LearnOpenGL", nullptr, nullptr);
    glfwMakeContextCurrent(window);

    // Set this to true so GLEW knows to use a modern approach to retrieving function pointers and extensions
    glewExperimental = GL_TRUE;
    // Initialize GLEW to setup the OpenGL Function pointers
    glewInit();

    // Define the viewport dimensions
    int width, height;
    glfwGetFramebufferSize(window, &width, &height);
    glViewport(0, 0, width, height);

    // Build and compile our shader program
    // Vertex shader
    GLuint vertexShader = glCreateShader(GL_VERTEX_SHADER);
    glShaderSource(vertexShader, 1, &vertexShaderSource, NULL);
    glCompileShader(vertexShader);
    // Check for compile time errors
    GLint success;
    GLchar infoLog[512];
    glGetShaderiv(vertexShader, GL_COMPILE_STATUS, &success);
    if (!success)
    {
        glGetShaderInfoLog(vertexShader, 512, NULL, infoLog);
        std::cout << "ERROR::SHADER::VERTEX::COMPILATION_FAILED\n" << infoLog << std::endl;
    }
    // Fragment shader
    GLuint fragmentShader = glCreateShader(GL_FRAGMENT_SHADER);
    glShaderSource(fragmentShader, 1, &fragmentShaderSource, NULL);
    glCompileShader(fragmentShader);
    // Check for compile time errors
    glGetShaderiv(fragmentShader, GL_COMPILE_STATUS, &success);
    if (!success)
    {
        glGetShaderInfoLog(fragmentShader, 512, NULL, infoLog);
        std::cout << "ERROR::SHADER::FRAGMENT::COMPILATION_FAILED\n" << infoLog << std::endl;
    }
    // Link shaders
    GLuint shaderProgram = glCreateProgram();
    glAttachShader(shaderProgram, vertexShader);
    glAttachShader(shaderProgram, fragmentShader);
    glLinkProgram(shaderProgram);
    // Check for linking errors
    glGetProgramiv(shaderProgram, GL_LINK_STATUS, &success);
    if (!success) {
        glGetProgramInfoLog(shaderProgram, 512, NULL, infoLog);
        std::cout << "ERROR::SHADER::PROGRAM::LINKING_FAILED\n" << infoLog << std::endl;
    }
    glDeleteShader(vertexShader);
    glDeleteShader(fragmentShader);


    // Set up vertex data (and buffer(s)) and attribute pointers
    // We add a new set of vertices to form a second triangle (a total of 6 vertices); the vertex attribute configuration remains the same (still one 3-float position vector per vertex)
    GLfloat vertices[] = {
        // First triangle
        -0.9f, -0.5f, 0.0f,  // Left
        -0.0f, -0.5f, 0.0f,  // Right
        -0.45f, 0.5f, 0.0f,  // Top
        // Second triangle
         0.0f, -0.5f, 0.0f,  // Left
         0.9f, -0.5f, 0.0f,  // Right
         0.45f, 0.5f, 0.0f   // Top
    };
    GLuint VBO, VAO;
    glGenVertexArrays(1, &VAO);
    glGenBuffers(1, &VBO);
    // Bind the Vertex Array Object first, then bind and set vertex buffer(s) and attribute pointer(s).
    glBindVertexArray(VAO);

    glBindBuffer(GL_ARRAY_BUFFER, VBO);
    glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW);

    glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3 * sizeof(GLfloat), (GLvoid*)0);
    glEnableVertexAttribArray(0);

    glBindBuffer(GL_ARRAY_BUFFER, 0); // Note that this is allowed, the call to glVertexAttribPointer registered VBO as the currently bound vertex buffer object so afterwards we can safely unbind

    glBindVertexArray(0); // Unbind VAO (it's always a good thing to unbind any buffer/array to prevent strange bugs)

    // Game loop
    while (!glfwWindowShouldClose(window))
    {
        // Check if any events have been activiated (key pressed, mouse moved etc.) and call corresponding response functions
        glfwPollEvents();

        // Render
        // Clear the colorbuffer
        glClearColor(0.2f, 0.3f, 0.3f, 1.0f);
        glClear(GL_COLOR_BUFFER_BIT);

        // Draw our first triangle
        glUseProgram(shaderProgram);
        glBindVertexArray(VAO);
        glDrawArrays(GL_TRIANGLES, 0, 6); // We set the count to 6 since we're drawing 6 vertices now (2 triangles); not 3!
        glBindVertexArray(0);

        // Swap the screen buffers
        glfwSwapBuffers(window);
    }
    // Properly de-allocate all resources once they've outlived their purpose
    glDeleteVertexArrays(1, &VAO);
    glDeleteBuffers(1, &VBO);
    // Terminate GLFW, clearing any resources allocated by GLFW.
    glfwTerminate();
    return 0;
}

(code take from here)

Run this with g++ -o it.exe -lglfw -lGL -lGLEW it.cpp && ./it.exe and you'll see what I mean. Then it displays correctly if you comment out line 36.

[vaxerski]

can I get a WAYLAND_DEBUG=1?

[Dregu]

This is yet another manifestation of libdecor 0.2.4, and adding glfwInitHint(GLFW_WAYLAND_LIBDECOR, GLFW_WAYLAND_DISABLE_LIBDECOR); before glfwInit fixes it and I assume downgrading to libdecor 0.2.3 also fixes it. I don't know enough to actually blame libdecor for this, but someone is using the wrong window sizes when libdecor is involved but decorations are not actually used.

Discord has shown something similar also happens in eglgears, vkgears and godot with libdecor 0.2.4.

[zacoons]

What Dregu said seems right. Here are the logs anyway though:
itlog.txt

[vaxerski]

this is not a hl bug

[zacoons]

this is not a hl bug

It behaves differently in other compositors, but I'll take your word for it.

[Dregu]

I also tried 3 other tiling compositors and they all worked great with libdecor 0.2.4 and this demo.

[vaxerski]

I can also write a program that bugs on hyprland:
if (xdg_current_desktop == "Hyprland")
bug();

doesn't mean it's a hyprland issue

[gulafaran]

as far as ive digged ive comed to the conclusion https://gitlab.freedesktop.org/libdecor/libdecor/-/commit/700aa1e6fb5dddc085d94dddf480e74b84c0ad88 changed so it applies window max/min size on fullscreen and also maximized applications. however maximized applications does not have borders.

the libdecor code incorporates border sizes even if maximized and sends a xdg_surface::set_window_geometry with a -37 offset for this. meaning in hyprland everything is now -37 offset even tho it has no borders, would be same issue in other compositors if being set maximized. firefox had a similiar issue in 2018 https://hg-edge.mozilla.org/mozilla-central/rev/61ef04097971 that reset this offset on maximized. so yeah looks like libdecor issue

[hanatos]

thanks for all the input on this issue. i was experiencing the same. while we wait for libdecor to fix it: setting the hint

glfwWindowHint(GLFW_WAYLAND_LIBDECOR, GLFW_WAYLAND_DISABLE_LIBDECOR); 

didn't work for me, but as a workaround i set the client fullscreen mode in hyprland.conf like

windowrulev2 = fullscreenstate 0 3,class:^(vkdt)$,title:^(vkdt)$

note that in hyprland-git (on arch) i see the offset only during mouse move events, not during rendering or mouse down events. the above config line makes it work as expected until i fullscreen and unfullscreen my window.

[Dregu]

You should read my comment about the hint again cause yours is wrong.

[hanatos]

right. thanks and ignore me :) glfwInitHint actually works as you describe.

[its-mrarsikk]

Is there going to be a fix for this? I don't exactly want to set window rules to make my program work as a long-term solution.

[gulafaran]

https://gitlab.freedesktop.org/libdecor/libdecor/-/issues/80

[Dregu]

I also found that libdecor will gracefully fallback to no decorations or wonky geometry calculations if it can't find any plugins, so you can env = LIBDECOR_PLUGIN_DIR,pleasegoaway to disable it globally...

[gulafaran]

https://gitlab.freedesktop.org/libdecor/libdecor/-/merge_requests/173

[Dregu]

It seems to fix some of the issues, but non-resizable windows are still the wrong size. This example is supposed to be 800x600, imgui example is supposed to be 1280x800, both open with whatever random size hyprland allocated for the next tiled window with this MR, even though it floats. Non-resizable window should get the size it asked for, but it never asks now I guess? The glfw requested sizes work fine with libdecor disabled completely.

[gulafaran]

go and mention that on the issue https://gitlab.freedesktop.org/libdecor/libdecor/-/issues/80 preferrably perhaps with some repro steps

[gulafaran]

unless ofc its worthy of another issue itself