Hook system in shambles

[Dregu]

All my hook-based plugins broke and crash on load after rebuilding on 5a20862. The mouse one also started crashing without that commit when dragging browser tabs. I really cba to investigate this a lot, but the actual hooked code has never really changed, yet my plugins keep breaking all the time actually and I keep making some spaghetti fixes that I don't really understand to stop the crashes.

I don't know if there's some specific way I'm supposed to be building hyprland and the plugins, but simple cmake with ninja for both used to work and now it doesn't. I just rewrote these as actual hl features and might try to hammer in some pr's one day, but I'm done with plugins for now, easier to maintain your own fork.

The plugins:

• https://github.com/Dregu/contactlens
• https://github.com/Dregu/magic-mouse-gaps

[vaxerski]

I tried magic mouse gaps and it seems to work for me

[vaxerski]

[khalid151]

I'm having the same issue. The original function doesn't execute anymore, which is the reason why Hyprland is crashing for me.

[khalid151]

I know. I'm not mix-and-matching packages. All I'm saying is that I've tried everything. Everything is built from zero.

I started from the ground up. Downloaded and built the dependencies. Built a release binary. Installed it. And ended up with a crash.

If the same build is NOT installed system-wide, and simply run directly, then the built plugin works properly.

And I obviously make sure that the plugin is built properly.

Anyway, is there anything wrong with the packaged binary of Hyprland on arch? And what about the hyprland-git in the AUR? I mean, installing it either way and building a plugin against it, shouldn't be resulting in a crash.

[khalid151]

I'm not sure what I've been doing wrong but it's working now..? Purged everything, uninstalled Hyprland, and just installed the arch binary package. I rebuilt the plugin and to my surprise it works. There has to be something to it as I KNOW that I started getting this issue after an update. If I could reproduce, I'll make sure to post it. Anyway, thanks for taking the time to read this mess.

[khalid151]

So.... Can you not have different plugins that hook on the same function now?
I figured that what's causing the crash is simply loading two different plugins that hook on that same constructor.

Can you try loading both of these at the same time?
https://github.com/khalid151/csd-titlebar-move
https://github.com/khalid151/hyprland-minimize-plugin

I could do that before and had no issues. Both worked without crashing hyprland. Now I have to keep one of them only.

[vaxerski]

it was never safe or correct to have two plugins hook the same point. Maybe it "worked" before, but it would very quickly break if one of them decided to unhook. Honestly, I should probably just make hooks fail to register if there's already a hook in-place.

[vaxerski]

I'm disallowing that in #12320