Firefox/Firefox Based browsers >= Version 142 crash when display is disconnected. #11529
-
|
Firefox and Firefox based browsers (such as Librewolf) crash when disconnecting monitors, such as using a KVM switch. This crash does not occur under Gnome. Attached are the wayland log from Firefox and the coredump. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1984696 firefox-nightly-wayland-144.0a1.20250823.091702.log |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments 10 replies
-
|
KDE had the same issue with Firefox crashing. This was their solution https://invent.kde.org/plasma/kwin/-/merge_requests/8029 |
Beta Was this translation helpful? Give feedback.
-
|
@UjinT34 potentially Hyprland/src/protocols/ColorManagement.cpp Lines 76 to 79 in 4b2bfbd maybe don't throw an error there and somehow create an inert obj? |
Beta Was this translation helpful? Give feedback.
-
|
I would be happy to provide additional logs or debugging info, would just need a bit of guidance on what and where, as I am not very familiar with the Hyprland codebase. The issue is easy to reproduce on my end. |
Beta Was this translation helpful? Give feedback.
-
|
I don't think that HL has enough logging for this case atm. |
Beta Was this translation helpful? Give feedback.
-
|
You say you need more logs. Can you give us what flows you want loggged? And where logs need to be added so you know that were not passing some bad inputs. Can you meantion the lines @UjinT34 . |
Beta Was this translation helpful? Give feedback.
-
|
Some modifications are needed to log passed output ids to make sure that HL passes only valid ids to FF and emits necessary events to keep FF output list in sync. If the issue is caused by some output id or event mixup on HL side then we should fix it first. |
Beta Was this translation helpful? Give feedback.
-
|
I've added diff --git a/src/protocols/ColorManagement.cpp b/src/protocols/ColorManagement.cpp
index d126fea2..5ca2747a 100644
--- a/src/protocols/ColorManagement.cpp
+++ b/src/protocols/ColorManagement.cpp
@@ -811,13 +811,16 @@ void CColorManagementProtocol::bindManager(wl_client* client, void* data, uint32
void CColorManagementProtocol::onImagePreferredChanged(uint32_t preferredId) {
for (auto const& feedback : m_feedbackSurfaces) {
feedback->m_resource->sendPreferredChanged(preferredId);
+ LOGM(ERR, "Sending Preferred Id {}", preferredId);
}
}
void CColorManagementProtocol::onMonitorImageDescriptionChanged(WP<CMonitor> monitor) {
for (auto const& output : m_outputs) {
- if (output->m_monitor == monitor)
+ if (output->m_monitor == monitor) {
output->m_resource->sendImageDescriptionChanged();
+ LOGM(ERR, "Sending Image Description Changed. Output {}", output->m_monitor->m_name);
+ }
}
// recheck feedbacks
for (auto const& feedback : m_feedbackSurfaces)
But the logs are never printed. Also set breakpoints on those logs via gdb, but they weren't triggered. I would have assumed it would be printed around this area. Hyprlandd.log |
Beta Was this translation helpful? Give feedback.
-
|
I can reproduce this every time hypridle kicks in, or with the terminal: |
Beta Was this translation helpful? Give feedback.
-
|
I second this. I have similar issues when unplugging my ThinkPad dock connected to two external monitors Here are the logs when launching firefox from terminal |
Beta Was this translation helpful? Give feedback.
-
|
Same problem here, disconnecting from a Lenovo Hybrid dock with one HDMI and one DP monitor attached to it. Some (potentially) relevant information from the Firefox crash logs: |
Beta Was this translation helpful? Give feedback.
-
|
Try #11916 |
Beta Was this translation helpful? Give feedback.
-
|
This PR does prevent Firefox from crashing. |
Beta Was this translation helpful? Give feedback.
-
|
Could we get a release with this fix? (@vaxerski) |
Beta Was this translation helpful? Give feedback.
-
|
eventually yes |
Beta Was this translation helpful? Give feedback.
Try #11916