Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search query is lost when editing profile #4224

Open
seanh opened this issue Dec 14, 2016 · 1 comment
Open

Search query is lost when editing profile #4224

seanh opened this issue Dec 14, 2016 · 1 comment
Labels

Comments

@seanh
Copy link
Contributor

seanh commented Dec 14, 2016

My username, and anything else I had typed into the search bar, disappears when I click on Edit profile:

peek 2016-12-14 19-12

If you click the <- Back to your profile page link then the user name reappears in the search bar.

I think at least the username should be preserved when on the edit profile pages.

It'd be more consistent with other search behaviours if the other search terms were preserved as well.

@nickstenning
Copy link
Contributor

I'm not really sure I like the idea that your current search is a thing that's supposed to persist across every page on the site. It would make most sense to me for us to just remove the search bar from the user profile edit pages entirely. Relevant issue: #4223.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants