Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LMS-specific mentions behaviors #6886

Closed
3 of 4 tasks
acelaya opened this issue Mar 12, 2025 · 1 comment
Closed
3 of 4 tasks

Handle LMS-specific mentions behaviors #6886

acelaya opened this issue Mar 12, 2025 · 1 comment
Assignees

Comments

@acelaya
Copy link
Contributor

acelaya commented Mar 12, 2025

We can either add a new sidebar embedder config option that the LMS will set to change some behaviors, or use some of the existing mechanisms we have to determine if the sidebar is running in the LMS context.

Some different known behaviors are:

  • Replace rendered mentions by the display name instead of the username.
  • Do not render at-mentions as links to the user profile.
  • Show only display name in the suggestions popover.
  • Do not show a mention popover, or at least do not show the username on it.

Additionally, unwrapped/plain-text mentions (for when opening the editor) should have some format which ensures whitespaces are preserved. This was not needed for username-based mentions.

These are some possibilities:

  1. @<John Doe>
  2. @[John Doe]
  3. @John_Doe (replace spaces with underscores, although this could conflict if the underscore actually appears in the display name)
@acelaya
Copy link
Contributor Author

acelaya commented Mar 19, 2025

I'm closing this as completed. The most important pieces are done, and the only thing left is deciding how to deal with the mention popover. I have created a separate issue for that #6910

@acelaya acelaya closed this as completed Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant