-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date-fns wrong dependency in package.json #615
Comments
Note - I'm locally resolving this issue by adding on my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the issue
date-fns
should be independencies
, otherwise apps won't start.[BUG] Bug Reproduce Steps
react-date-range
without installingdate-fns
.Module not found: Error: Can't resolve 'date-fns/max' in '[...]\node_modules\react-date-range\dist\components\Calendar'
[BUG] Expected behaviour
As this package uses
date-fns
(in Calendar for example), it should be a dependency and not a peerDependency, which will makenpm install
ing this package also install the neededdate-fns
package.Environment
Package Version: 1.4.0
React version: 17.0.2
Node version: 16.16.0
The text was updated successfully, but these errors were encountered: