Socket.io-client error + undefined filename #8

hhumphrey-dazn · 2016-09-15T12:39:34Z

I'm coming across a couple of issues and just wanted to check before opening a PR. First when I run this within my tvml project I get

TypeError: undefined is not an object (evaluating 'Object.prototype')

This seems to stem from socket.io-client v1.4+:

Reverting back to 1.3.7 fixes the issue.

Also filename is missing from the method readFileContent, easily fixable and I'm happy to open a new PR if preferred.

The text was updated successfully, but these errors were encountered:

hypery2k · 2016-09-15T13:09:41Z

would be great if you fill a PR as I'm currently busy with other stuff

hypery2k · 2016-09-30T18:06:21Z

I've published version 0.3.0

hhumphrey-dazn · 2016-10-03T08:31:17Z

Thank you! This didn't include #7 any particular reason why?

hypery2k · 2016-10-03T08:44:25Z

sorry my fault. Will fix this

hypery2k added this to the 0.3.0 milestone Sep 15, 2016

hypery2k added the bug label Sep 15, 2016

hhumphrey-dazn mentioned this issue Sep 15, 2016

hot fixes for socket.io and filename issue #9

Merged

hypery2k added a commit that referenced this issue Sep 30, 2016

Fixing #8

3067359

hypery2k added a commit that referenced this issue Sep 30, 2016

Fixing #8

aaa3957

hypery2k closed this as completed Sep 30, 2016

hypery2k self-assigned this Oct 3, 2016

hypery2k mentioned this issue Oct 3, 2016

Increase flexibility for liveReload injection #10

Closed

hypery2k added a commit that referenced this issue Oct 3, 2016

Fix linting errors (#8)

5a57b04

Provide feedback