-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy with respect to OTel semantics in db call span #155
Comments
Also, according to the Otel semantics the key for Span kind is |
@rish691 could you please provide link/quote to spec where it mandates these attributes? Is it here https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md
I assume the OTEL agent uses |
Additional attribute requirements: At least one of the following sets of attributes is required: |
Tracked upstream in open-telemetry/opentelemetry-java-instrumentation#1521 |
I have a pr on the platform to handle this. So, this issue shouldn't block our testing at the moment. |
I belive the change - https://github.com/hypertrace/hypertrace-ingester/pull/84/files - is supposed to do workaround. |
The semantics mandate the presence of
net.peer.name
ornet.peer.ip
and conditionallynet.peer.port
attributes.These attributes are absent in the span reported by HT Java agent
Attaching the screen shot for a span.
cc @pavolloffay @davexroth
The text was updated successfully, but these errors were encountered: