Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy with respect to OTel semantics in db call span #155

Open
findingrish opened this issue Dec 5, 2020 · 6 comments
Open

Discrepancy with respect to OTel semantics in db call span #155

findingrish opened this issue Dec 5, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@findingrish
Copy link

The semantics mandate the presence of net.peer.name or net.peer.ip and conditionally net.peer.port attributes.
These attributes are absent in the span reported by HT Java agent

Attaching the screen shot for a span.
Screenshot 2020-12-05 at 6 53 35 PM

cc @pavolloffay @davexroth

@findingrish
Copy link
Author

Also, according to the Otel semantics the key for Span kind is span_kind

@pavolloffay
Copy link
Member

@rish691 could you please provide link/quote to spec where it mandates these attributes? Is it here https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md

Also, according to the Otel semantics the key for Span kind is span_kind

I assume the OTEL agent uses span_kind but then it gets converted to span.span in the OC service (collector). The platform should support span.kind orthogonally to this since it's a widely used tag.

@findingrish
Copy link
Author

findingrish commented Dec 7, 2020

Additional attribute requirements: At least one of the following sets of attributes is required:
net.peer.name
net.peer.ip

@pavolloffay
Copy link
Member

Tracked upstream in open-telemetry/opentelemetry-java-instrumentation#1521

@pavolloffay pavolloffay added the bug Something isn't working label Dec 7, 2020
@findingrish
Copy link
Author

I have a pr on the platform to handle this. So, this issue shouldn't block our testing at the moment.

@kotharironak
Copy link

I belive the change - https://github.com/hypertrace/hypertrace-ingester/pull/84/files - is supposed to do workaround.

@ryandens ryandens added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants