Merge pull request opal#1936 from Mogztter/issue-1902-string-chomp-one-char

elia · web-flow · commit 31d26d697ab7 · 2019-01-26T23:59:03.000+01:00
chomp must return an empty String when arg == self
diff --git a/opal/corelib/string.rb b/opal/corelib/string.rb
@@ -307,7 +307,7 @@ def chomp(separator = $/)
       else if (separator === "") {
         result = self.replace(/(\r?\n)+$/, '');
       }
-      else if (self.length > separator.length) {
+      else if (self.length >= separator.length) {
         var tail = self.substr(self.length - separator.length, separator.length);
 
         if (tail === separator) {

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ def chomp(separator = $/)`
`307`	`307`	`else if (separator === "") {`
`308`	`308`	`result = self.replace(/(\r?\n)+$/, '');`
`309`	`309`	`}`
`310`		`- else if (self.length > separator.length) {`
	`310`	`+ else if (self.length >= separator.length) {`
`311`	`311`	`var tail = self.substr(self.length - separator.length, separator.length);`
`312`	`312`
`313`	`313`	`if (tail === separator) {`