Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting gRPC with TLS on Java 8 #144

Closed
danielmai opened this issue May 14, 2020 · 1 comment · Fixed by #146
Closed

Supporting gRPC with TLS on Java 8 #144

danielmai opened this issue May 14, 2020 · 1 comment · Fixed by #146
Assignees
@abhimanyusinghgaur
Labels
area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it

Comments

@danielmai
Copy link
Contributor

By default, TLS over gRPC is only supported on Java 9 and later. Java 9 is no longer supported.

According to grpc-java, we can include grpc-netty-shaded as part of dgraph4j so that the necessary SSL libraries are available for Java 8 for Windows, macOS, and Linux:

JDK versions prior to Java 9 do not support ALPN and are either missing AES GCM support or have 2% the performance of OpenSSL.

We recommend most users use grpc-netty-shaded, which includes netty-tcnative on BoringSSL. It includes pre-built libraries for 64 bit Windows, OS X, and 64 bit Linux. For 32 bit Windows, Conscrypt is an option. For all other platforms, Java 9+ is required.

Java 8 and Java 11 are the current Java LTS releases, so it makes sense to support Java 8 for users that are still on that version.

What do you think, @abhimanyusinghgaur?
@abhimanyusinghgaur
Copy link
Contributor

Yes, I agree. I will test this on my system and see if it works.

@danielmai danielmai added area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it labels May 14, 2020
@abhimanyusinghgaur abhimanyusinghgaur mentioned this issue May 18, 2020
Merged
@abhimanyusinghgaur abhimanyusinghgaur self-assigned this May 18, 2020
abhimanyusinghgaur added a commit that referenced this issue May 19, 2020
@abhimanyusinghgaur
Update Java v1.8.x support in README.md (#146)
8589f92 
Fixes #144.

Not adding a test because of following reasons:

Can't add the dependency in dgraph4j as it will enforce it for all java versions, which in not what we want.
Can't add it in DgraphJavaSample, as people will be looking at it irrespective of java version they use. So, I think its better for it to stay as is. Just the documentation update should be enough to guide people who face problems with Java 1.8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhimanyusinghgaur abhimanyusinghgaur

Labels
area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Java v1.8.x support in README.md hypermodeinc/dgraph4j
2 participants
@danielmai @abhimanyusinghgaur