Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.slf4j/slf4j-simple as a compile-time dependency is incorrect #131

Closed
vxe opened this issue Feb 15, 2020 · 0 comments · Fixed by #133
Closed

org.slf4j/slf4j-simple as a compile-time dependency is incorrect #131

vxe opened this issue Feb 15, 2020 · 0 comments · Fixed by #133
Labels
investigate kind/bug Something is broken. priority/P1 Serious issue that requires eventual attention (can wait a bit) status/needs-attention The issue needs more eyes on it, more investigation might be required before accepting/rejecting it

Comments

@vxe
Copy link

vxe commented Feb 15, 2020

Hello dgraph maintainers, it seems that slf4j gets propagated to projects which pull in dgraph4j as a maven dependency, see below

This is a bug in dgraph4j, which lists org.slf4j/slf4j-simple as a compile-time dependency in the default scope. Libraries should not propagate specific slf4j bindings to dependent projects - see the slf4j FAQ.

Please file a bug report with dgraph4j, telling them to scope their dependency on org.slf4j/slf4j-simple correctly to stop it propagating to other people's projects. You could link them to this comment.

fzakaria/slf4j-timbre#38

thanks!
@shekarm shekarm added investigate kind/bug Something is broken. priority/P1 Serious issue that requires eventual attention (can wait a bit) status/needs-attention The issue needs more eyes on it, more investigation might be required before accepting/rejecting it labels Feb 19, 2020
@martinmr martinmr mentioned this issue Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate kind/bug Something is broken. priority/P1 Serious issue that requires eventual attention (can wait a bit) status/needs-attention The issue needs more eyes on it, more investigation might be required before accepting/rejecting it
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix slf4j dependencies. hypermodeinc/dgraph4j
2 participants
@vxe @shekarm