Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client should support close method #122

Closed
willem520 opened this issue Jan 7, 2020 · 2 comments
Closed

client should support close method #122

willem520 opened this issue Jan 7, 2020 · 2 comments
Labels
area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it

Comments

@willem520
Copy link

willem520 commented Jan 7, 2020

now,the close method is not convenient
image
it means we should save channel by myself,maybe we should provide client close methd like
public void close(){ channels.stream().forEach(item -> { item.shutdown(); }); }
or more easy to use

@danielmai danielmai added area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it labels Jan 14, 2020
@mangalaman93
Copy link
Member

If we do this, we could add at least following 3 functions-

  • open
  • openWithTLS
  • close

@minhaj-shakeel
Copy link
Contributor

minhaj-shakeel commented Jul 20, 2020

Github issues have been deprecated.
This issue has been moved to discuss. You can follow the conversation there and also subscribe to updates by changing your notification preferences.

drawing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Issues with usability and error messages kind/enhancement Something could be better. status/accepted We were able to reproduce the issue and accept to work on it
Development

No branches or pull requests

4 participants