Skip to content

Trunk golangci-lint configuration is missing previously configured linters #9387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xqqp opened this issue Apr 16, 2025 · 3 comments
Open
Assignees
Labels

Comments

@xqqp
Copy link
Contributor

xqqp commented Apr 16, 2025

It seems when the migration to Trunk was made the golangci-lint configuration file was not transitioned (https://github.com/hypermodeinc/dgraph/blob/v24.0.5/.golangci.yml). In case this was an oversight, the old configuration file should be used again to ensure a consistent coding style.

@xqqp xqqp added the bug label Apr 16, 2025
Copy link

linear bot commented Apr 16, 2025

@harshil-goel
Copy link
Contributor

Is there anything that you find we are not checking anymore?

@xqqp
Copy link
Contributor Author

xqqp commented Apr 16, 2025

The config file for golangci-lint on the main branch is pretty much empty: https://github.com/hypermodeinc/dgraph/blob/main/.trunk/configs/.golangci.json
So I assume all the linters previously configured are not used anymore. Or is there a separate configuration file?

@ryanfoxtyler ryanfoxtyler self-assigned this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants