Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant trigger-domain_id connection #4630

Open
Stukalov-A-M opened this issue May 21, 2024 · 2 comments · Fixed by #4640
Open

Remove a redundant trigger-domain_id connection #4630

Stukalov-A-M opened this issue May 21, 2024 · 2 comments · Fixed by #4640
Assignees
Labels
iroha2 Refactor Improvement to overall code quality

Comments

@Stukalov-A-M
Copy link
Contributor

Remove a redundant trigger-domain_id connection

ref. #4616 (comment)

I think we should remove connection of a trigger with a domain_id. It doesn't make sense because each trigger's authority already has this connection. Moreover, it creates some redundant difficulties in cases of permission granting and checking ref is_trigger_owner()

Minimum working example

Proposed a new trigger structure

    pub struct Trigger {
        /// [`Id`] of the [`Trigger`].
        pub id: Name,
        /// Action to be performed when the trigger matches.
        pub action: action::Action,
    }
@nxsaken
Copy link
Contributor

nxsaken commented May 22, 2024

I'd like to try handling this. Is that fine?

@Stukalov-A-M
Copy link
Contributor Author

I'd like to try handling this. Is that fine?

I have no objections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2 Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants