Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage measurement targets #4584

Open
s8sato opened this issue May 14, 2024 · 2 comments
Open

coverage measurement targets #4584

s8sato opened this issue May 14, 2024 · 2 comments
Labels
CI question Further information is requested

Comments

@s8sato
Copy link
Contributor

s8sato commented May 14, 2024

Originally posted by @s8sato in #4573 (comment)

Define appropriate coverage measurement targets:

  • Numerator:
    • Should coverage by p2p/tests/integration be considered?
  • Denominator:
    • What parts of the code do not need to be covered by tests?
@s8sato
Copy link
Contributor Author

s8sato commented Aug 19, 2024

Currently, our coverage is failing to ignore certain paths:
The coverage generating command expects client_cli should be ignored, while sonar (you may need to request access to DevOps) detects 753 uncovered lines in client_cli/pytests.
A weird thing is that the source of the coverage report (lcov.info as a CI artifact e.g. as seen here) does not mention client_cli except for client_cli/build.rs which has 0 uncovered lines

@BAStos525
Copy link
Member

Solved via Sonarqube settings

Currently, our coverage is failing to ignore certain paths: The coverage generating command expects client_cli should be ignored, while sonar (you may need to request access to DevOps) detects 753 uncovered lines in client_cli/pytests. A weird thing is that the source of the coverage report (lcov.info as a CI artifact e.g. as seen here) does not mention client_cli except for client_cli/build.rs which has 0 uncovered lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants