We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torii
I feel strange that torii is used to "block" iroha.
Imo it would be simpler design if iroha would always spawn torii in sparate task as any other service.
torii
And on iroha start we would just listen on notify_sender:
start
notify_sender
async fn start(self) { self.notify_sender.notified().await }
This way iroha user is free to either block on this and wait on shutdown or start it as task.
Originally posted by @Erigara in #4456 (comment)
The text was updated successfully, but these errors were encountered:
Erigara
Successfully merging a pull request may close this issue.
Imo it would be simpler design if iroha would always spawn
torii
in sparate task as any other service.And on iroha
start
we would just listen onnotify_sender
:This way iroha user is free to either block on this and wait on shutdown or start it as task.
Originally posted by @Erigara in #4456 (comment)
The text was updated successfully, but these errors were encountered: