-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitmap repr field in schema #4524
Comments
Currently the repr just corresponds to the underlying rust type used, as it was just simpler to implement. The design is also somewhat loosely based on bitflags crate, although there the signedness actually does matter, for generated methods like In the end, I agree that this is better represented by the amount of bits in the mask; if downstream users of the schema haven't started relying on this (SDKs, iroha2 docs, something else?). I've implemented support in docs (hyperledger/iroha-2-docs@f1ab8d4), though that is still pretty easy to update |
I don't think that unsigned vs signed conveys meaningful information for a bitmap, rather it should be
"repr": 32
The text was updated successfully, but these errors were encountered: