Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename iroha_client_cli into iroha #4512

Closed
mversic opened this issue Apr 25, 2024 · 4 comments · Fixed by #4662
Closed

Rename iroha_client_cli into iroha #4512

mversic opened this issue Apr 25, 2024 · 4 comments · Fixed by #4662
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Apr 25, 2024

It makes much more sense for the end user to just call iroha when interacting with cli, wouldn't you agree?

@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested labels Apr 25, 2024
@nxsaken
Copy link
Contributor

nxsaken commented May 21, 2024

@DCNick3
Copy link
Contributor

DCNick3 commented May 21, 2024

The peer executable should be renamed too then. Maybe irohad, like some common linux daemons?

@nxsaken
Copy link
Contributor

nxsaken commented May 21, 2024

Alternatively, it might be time to consult the Japanese dictionary? We already have Torii, which is one kind of interface. The client, client CLI, and the peer CLI are interfaces too, so we could make them consistent with the rest of the Iroha lore. Might be too much though.

@mversic
Copy link
Contributor Author

mversic commented May 21, 2024

Alternatively, it might be time to consult the Japanese dictionary?

I wouldn't in this case. I think iroha and irohad would be more recognizable as a brand. Otherwise, it would be difficult to figure out how to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants