-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View changes in idle conditions #3103
Comments
One downside i observed so far is that if idle state continues for large amount of time view change proofs we send with every message became bigger and bigger slowing down message processing. |
Since the #3166 bug we're not doing view changes on idle. Should we or should we not can still be discussed in this ticket |
The whitepaper states that once a valid set
A
is found it should be kept, i.e. not mixed with setB
until there is a consensus failure. From a performance perspective this makes sense, we don't want to waste time on determining non-faulty peers that comprise setA
on everysumeragi
roundThe question is whether we want to do view changes when there are no transactions. Current situation is such that we do view changes every time a block isn't produced in due time. A block may not be produced because of faulty peers in set
A
or because there are no transactions.Benefits
A
) will always be validating peers unless one of the nodes becomes faulty. Low contention is the perfect time to bring in observing nodes to consensus and, consequently, recreate setsA
andB
. Mitigating censorship is the reason why we change setA
peer roles as per the whitepaperDownsides
This discussion is relevant
The text was updated successfully, but these errors were encountered: