Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate What Must Be Done to Enable Actions #1367

Open
onelapahead opened this issue Jul 11, 2023 · 0 comments
Open

Indicate What Must Be Done to Enable Actions #1367

onelapahead opened this issue Jul 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@onelapahead
Copy link
Contributor

onelapahead commented Jul 11, 2023

https://github.com/search?q=repo%3Ahyperledger%2Ffirefly%20MsgActionNotSupported&type=code

whenever a certain action is not supported, whether its because multi-party is not enabled or because a specific plugin is not enabled on the namespace, the above error is returned.

While it makes it clear the action cannot be performed, it does not elucidate as to why it cannot be performed. This can make for a wanting error experience, where the user needs to squint at their namespace config, maybe read FF source, and guess what they need to enable or add for the action to be allowed.

We should update this error (or make separate errors) to have a formatable section to provide what specifically prevents the action from being allowed, and if something could be done to fix that.

@onelapahead onelapahead added the enhancement New feature or request label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant