Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): migrate supply chain app to ethereum connector #3272

Closed
petermetz opened this issue May 19, 2024 · 11 comments · Fixed by #3380
Closed

docs(examples): migrate supply chain app to ethereum connector #3272

petermetz opened this issue May 19, 2024 · 11 comments · Fixed by #3380
Assignees
@petermetz
Labels
Breaking_V1 Changes that can only be made with the release of v2 due to them being breaking changes. good-first-issue Good for newcomers good-first-issue-400-expert P3 Priority 3: Medium Quorum
Milestone
v2.0.0

Comments

@petermetz
Copy link
Member

Description

There are plans to maybe remove the quorum connector in the future, but for that, we need to first make sure that the example supply chain app still works.
This means migrating the supply chain app from using quorum for storing one of the data entities to another connector such as the ethereum connector (but it could be another one if we figure out along the way as such)

A couple of relevant locations in the code of the supply chain example to speed up context gathering for this task:

  1. https://github.com/hyperledger/cacti/blob/main/examples/cactus-example-supply-chain-backend/src/main/typescript/infrastructure/supply-chain-app-dummy-infrastructure.ts#L172
  2. https://github.com/hyperledger/cacti/blob/main/examples/cactus-example-supply-chain-backend/src/main/typescript/infrastructure/supply-chain-app-dummy-infrastructure.ts#L192
  3. https://github.com/hyperledger/cacti/blob/main/examples/cactus-example-supply-chain-frontend/src/app/bamboo-harvest/bamboo-harvest-list/bamboo-harvest-list.page.ts#L44
  4. https://github.com/hyperledger/cacti/blob/main/examples/cactus-example-supply-chain-business-logic-plugin/src/main/typescript/business-logic-plugin/web-services/list-bamboo-harvest-endpoint.ts#L30

A branch that has the changes to remove the quorum connector and it's test utilities (AIO ledgers and such) from the project have already been pushed, but that branch has the build broken at the moment due to the supply chain app's dependency on the quorum connector.

The main goal of this issue is to eliminate that dependency so that the build can start passing on the above referenced branch:
https://github.com/petermetz/cacti/tree/refactor-connector-quorum-removal

Acceptance Criteria

  1. The supply chain app uses the ethereum connector
  2. Quorum references and dependency declarations have been removed from the supply chain app and it's packages.
  3. The refactor-connector-quorum-removal has the build passing after having been rebased onto the branch that will be created for fixing this issue.
@petermetz petermetz added good-first-issue Good for newcomers Quorum good-first-issue-400-expert P3 Priority 3: Medium Breaking_V1 Changes that can only be made with the release of v2 due to them being breaking changes. labels May 19, 2024
@petermetz petermetz added this to the v2.0.0 milestone May 19, 2024
@murluki
Copy link

murluki commented May 19, 2024

Could you please assign this issue to me?

@petermetz
Copy link
Member Author

Could you please assign this issue to me?

@murluki Yup, you got it! If you need any help, please feel free to reach out to me on the daily pair programming sessions that are open to everyone: https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls

@petermetz
Copy link
Member Author

@murluki Just checking in to make sure you are able to progress with this one. How is it going?

@murluki
Copy link

murluki commented May 31, 2024

I’ll upload the solution this weekend, but yes, if you don’t mind, could I jump on the call because I do have some questions?

@petermetz
Copy link
Member Author

@murluki Thank you for the update, very much appreciated! You are more than welcome to join the pair programming calls! The next one is coming up on Monday 10:00 AM Pacific Time!

@petermetz
Copy link
Member Author

@murluki Are you still working on this?

@murluki
Copy link

murluki commented Jun 19, 2024

Yes, sorry for making you wait. Finishing.

@petermetz
Copy link
Member Author

@murluki No worries, just keep me in the loop if I can help with any of it!

@murluki
Copy link

murluki commented Jun 19, 2024

Added the change and just checking where else it is used and running the tests/build, thank you!

@petermetz
Copy link
Member Author

@murluki If you share a link to the branch where you are working on, I could help speed things up a bit. :-)

@petermetz petermetz self-assigned this Jul 3, 2024
petermetz added a commit to petermetz/cacti that referenced this issue Jul 4, 2024
@petermetz
docs(examples): migrate supply chain app to ethereum connector
a54c4e1 
WORK IN PROGRESS

Fixes hyperledger#3272

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 4, 2024
@petermetz
docs(examples): migrate supply chain app to XDai connector
4bc1e7e 
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Fixes hyperledger#3272

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 4, 2024
@petermetz
docs(examples): migrate supply chain app to XDai connector
8a5d6a8 
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger#3272

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Jul 4, 2024
Merged
5 tasks
@petermetz petermetz assigned petermetz and unassigned petermetz and murluki Jul 4, 2024
@petermetz
Copy link
Member Author

@murluki Sorry, I have to take this one over to make sure it gets done soon.

petermetz added a commit to petermetz/cacti that referenced this issue Jul 6, 2024
@petermetz
docs(examples): migrate supply chain app to XDai connector
a08870e 
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger#3272

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 8, 2024
@petermetz
docs(examples): migrate supply chain app to XDai connector
6cb382a 
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger#3272

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 8, 2024
@petermetz
docs(examples): migrate supply chain app to XDai connector
e62ae86 
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger#3272

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Breaking_V1 Changes that can only be made with the release of v2 due to them being breaking changes. good-first-issue Good for newcomers good-first-issue-400-expert P3 Priority 3: Medium Quorum
Projects
Cacti_Scrum_Project_v2_Release
Status: Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

docs(examples): migrate supply chain app to XDai connector petermetz/cacti
2 participants
@petermetz @murluki