-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(coverage): change coverage_ts.yaml condition to use success only #3371
Comments
aldousalvarez
added a commit
to aldousalvarez/cactus
that referenced
this issue
Jul 19, 2024
Primary Changes ---------------- 1. Updated the condition in coverage_ts.yaml to run only when the CI run is successful Fixes hyperledger#3371 Signed-off-by: aldousalvarez <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
On PR #3285, there is a file that has a TypeScript code coverage statistics workflow
coverage_ts.yaml
. This workflow will only run afterCI.yaml
has finished all its jobs and if it is on the default branch, which is the main branch. But some of the jobs inCI.yaml
are currently failing, so to be able to test it after the merge to see if it is working, the condition used incoverage_ts.yaml
is:if: ${{ github.event.workflow_run.conclusion == 'failure' || github.event.workflow_run.conclusion == 'success' }}
and then once it is confirmed that it is working fine. We should just use success as the condition for coverage_ts.yaml
github.event.workflow_run.conclusion == 'success' }}
Acceptance Criteria
cc: @petermetz
The text was updated successfully, but these errors were encountered: