Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(coverage): change coverage_ts.yaml condition to use success only #3371

Closed
aldousalvarez opened this issue Jul 2, 2024 · 0 comments · Fixed by #3422
Closed

ci(coverage): change coverage_ts.yaml condition to use success only #3371

aldousalvarez opened this issue Jul 2, 2024 · 0 comments · Fixed by #3422
Assignees

Comments

@aldousalvarez
Copy link
Contributor

Description

On PR #3285, there is a file that has a TypeScript code coverage statistics workflow coverage_ts.yaml. This workflow will only run after CI.yaml has finished all its jobs and if it is on the default branch, which is the main branch. But some of the jobs in CI.yaml are currently failing, so to be able to test it after the merge to see if it is working, the condition used in coverage_ts.yaml is:

if: ${{ github.event.workflow_run.conclusion == 'failure' || github.event.workflow_run.conclusion == 'success' }}

and then once it is confirmed that it is working fine. We should just use success as the condition for coverage_ts.yaml

github.event.workflow_run.conclusion == 'success' }}

Acceptance Criteria

  1. The changes on PR ci(coverage): add total typescript code coverage statistics #3285 has been merged.
  2. Verify if coverage_ts.yaml runs on the main branch.

cc: @petermetz

aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Jul 19, 2024
Primary Changes
----------------
1. Updated the condition in coverage_ts.yaml to run only
   when the CI run is successful

Fixes hyperledger#3371

Signed-off-by: aldousalvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant