Skip to content

Commit 6dab159

Browse files
Make SV frontend test close modal more robust (#3261)
Signed-off-by: Julien Tinguely <[email protected]>
1 parent 7303f77 commit 6dab159

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SvFrontendIntegrationTest.scala

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ class SvFrontendIntegrationTest
846846
_ => checkNewVoteRequestInProgressTab(previousVoteRequestsInProgress),
847847
)
848848

849-
val (_, requestId) = actAndCheck(
849+
val (_, reviewButton) = actAndCheck(
850850
"sv1 operator creates a new vote request with a long expiration time", {
851851
submitSetDsoConfigRequestViaFrontend(
852852
numMemberTrafficContractsThreshold = "42"
@@ -855,16 +855,17 @@ class SvFrontendIntegrationTest
855855
)(
856856
"sv1 can see the new vote request in the progress tab",
857857
_ => {
858-
val reviewButton =
859-
checkNewVoteRequestInProgressTab(previousVoteRequestsInProgress + 1)
860-
reviewButton.underlying.click()
861-
val requestId =
862-
inside(find(id("vote-request-modal-content-contract-id"))) { case Some(tb) =>
863-
tb.text
864-
}
865-
requestId
858+
checkNewVoteRequestInProgressTab(previousVoteRequestsInProgress + 1)
866859
},
867860
)
861+
val requestId = eventually() {
862+
reviewButton.underlying.click()
863+
val requestId =
864+
inside(find(id("vote-request-modal-content-contract-id"))) { case Some(tb) =>
865+
tb.text
866+
}
867+
requestId
868+
}
868869

869870
clue("Resuming vote request expiration automation") {
870871
sv1Backend.dsoDelegateBasedAutomation.trigger[CloseVoteRequestTrigger].resume()

0 commit comments

Comments
 (0)