-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The example doesn't work with latest version 0.14.12 #68
Comments
Hi @chiro-hiro 👋🏻, I think you raise a great point. It would be helpful to annotate in some way which features are required to make these examples run. Also, since there are multiple 'primary versions' (if you will), it would be nice to see which version of Hyper (1.0 or otherwise) is being referenced in the code snippets outside the version-specific guide pages. What do you think? cc @oddgrd (I'd be happy to attempt whatever this issue manifests into 👍🏻) |
Hey Isaac! I think we have the imports covered in the guides, but they are missing for the example on the homepage. I suppose the reason they are not there on the homepage is to keep it brief. It would be nice to make it clear that the homepage code is 1.0, as you suggested. Perhaps we should link to the https://hyper.rs/guides/1/server/hello-world/ guide, since it's pretty much the same as the homepage but including imports? |
Good evening. I was wondering if this issue is already created and yes, it is :) |
The given code on your home page:
The result:
The text was updated successfully, but these errors were encountered: