Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make _dotted condition stricter #104

Closed
wants to merge 2 commits into from
Closed

Conversation

yiranlus
Copy link

@yiranlus yiranlus commented Oct 24, 2024

trying to fix #83

@yiranlus yiranlus marked this pull request as draft October 24, 2024 21:55
@yiranlus yiranlus marked this pull request as ready for review October 24, 2024 21:59
@Kodiologist
Copy link
Member

You'll need to get the old tests to pass, add a new test for your desired behavior, document it, add to NEWS, and add yourself to AUTHORS. See the contributor guidelines.

@yiranlus yiranlus marked this pull request as draft October 25, 2024 08:52
@yiranlus
Copy link
Author

Thanks @Kodiologist.

However, I am not able to pass test-bare-dotted. The problem is that 'str.upper produces exactly the same expression as '(. str upper), so _dotted can't distinguish if the passed node is a function from a class (or probably also from a module) or to access the property names unless we explicitly put them into the bracket.

@Kodiologist
Copy link
Member

Yep, that's what I was talking about in the linked issue. So, unless I'm missing something, this isn't going to work.

@yiranlus yiranlus closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-> no longer works with dot expression
2 participants