Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding support for other project formats by using MsBuildExtras #126

Closed
mungojam opened this issue Jun 18, 2018 · 9 comments
Closed

Comments

@mungojam
Copy link
Collaborator

I've successfully converted a couple of WPF projects by making use of https://github.com/onovotny/MSBuildSdkExtras which leaves me with a really nice tidy project file that debugs fine.

They aren't natively supported by the converter, so I had to first delete all the GUIDs to trick it and then override the SDK and delete a load of items from the project file afterwards, e.g. XAML and XAML.cs files.

I guess I could do it with the new custom transforms by removing these specific GUIDs beforehand and then overriding the SDK afterwards (probably not supported by ProjectDefinition at the moment but could be added.

Maybe that could be added as an option since you may not want to assume that people are happy with a third party SDK in their resultant projects. Hopefully Microsoft's own SDK will work for these projects in the next VS!

@MagicAndre1981
Copy link

Does this "extra SDK" support WinForms? I noticed after converting the csproj that the property page of the WinForms solution is very limited and misses options like Remote Debug.

@mungojam
Copy link
Collaborator Author

I think so, at least in the latest preview. I've asked them to clarify in the docs novotnyllc/MSBuildSdkExtras#87

@MagicAndre1981
Copy link

ok, I'll try this Extra thing and see how it works

@MagicAndre1981
Copy link

doesn't work for WinForms. Also the provided Sample is not working differently , it has the same issues as the SDK from Microsoft

@mungojam
Copy link
Collaborator Author

@MagicAndre1981 have you seen the mention on the readme that you have to add <ExtrasEnableWinFormsProjectSetup>true</ExtrasEnableWinFormsProjectSetup> for winforms? I think maybe that is just with the new version, but maybe only the new version supports WinForms.

I've used the previous version with WPF without any extra tags.

Also worth trying restarting VS and deleting .vs and .obj folders. Sometimes that does some magic..

@MagicAndre1981
Copy link

I've already added those settings and updated the csproj to use last dev build from myget, no difference.

@MagicAndre1981
Copy link

I also found a similar SDK:

https://www.nuget.org/packages/MSBuild.NET.Extras.Sdk/

but here the VS2017 hangs at "Preparing Solution..." and nothing happens.

@mungojam
Copy link
Collaborator Author

I've already added those settings and updated the csproj to use last dev build from myget, no difference.

Raise an issue with the project I reckon

@mungojam
Copy link
Collaborator Author

mungojam commented Jul 25, 2018

Fixed by #138

Thanks @andrew-boyarshin! have some 🍰 on me. I'll be able to remove my hacky pre and post transforms now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants