Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT missing tech debt #7351

Open
4 tasks
daneryl opened this issue Oct 14, 2024 · 0 comments
Open
4 tasks

AT missing tech debt #7351

daneryl opened this issue Oct 14, 2024 · 0 comments

Comments

@daneryl
Copy link
Collaborator

daneryl commented Oct 14, 2024

  • SaveTranslation is using the V1 entities save, We are doing this as a quick way of having denormalization in place, this should be reimplemented the v2 way, ideally when we finish AT.
  • Tests do not finish properly, we have no way of closing redis connection before test ends.
  • RequestEntityTranslation and ATServiceListener have duplicated knowledge, the service queue name
  • ATServiceListener receives a factory as its dependency. Rethink the process of injecting dependencies / factories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants