Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image sizings #3

Open
fnocetti opened this issue May 21, 2020 · 3 comments
Open

Fix image sizings #3

fnocetti opened this issue May 21, 2020 · 3 comments

Comments

@fnocetti
Copy link
Contributor

Markdown provides no way to set the images size so we need to use image files with the size we need them to be shown on the document.
By default it will use the maximum size it can fit on the article. This is particularly important for inline images (like those showing app icons) as they will use all the space they can, breaking the text.

@txau
Copy link
Collaborator

txau commented May 21, 2020

@fnocetti I guess regular html is supported for images in GitHub since a while ago:

<img src="https://github.com/favicon.ico" width="48">

Resulting in:

@fnocetti
Copy link
Contributor Author

@txau you're right. But I forgot to say that using html inside the markdown messes with the PDF generation.

@nwyu nwyu self-assigned this May 23, 2020
@nwyu
Copy link
Contributor

nwyu commented May 23, 2020

All icons have been resized. Still need to resize other images and scrub files for [image alt text] so this text does not appear improperly on the pdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants